-
Notifications
You must be signed in to change notification settings - Fork 20.1k
refactor: refactor Ceil
and improved tests
#6366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6366 +/- ##
============================================
- Coverage 74.64% 74.63% -0.02%
- Complexity 5445 5450 +5
============================================
Files 682 682
Lines 19000 19003 +3
Branches 3668 3669 +1
============================================
Hits 14182 14182
- Misses 4260 4261 +1
- Partials 558 560 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you also test edge cases like Double.MAX_VALUE, Double.MIN_VALUE, Zero, NaN, and Infinity to ensure the method handles them correctly?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, fixed it. Now everything works like Math.ceil.
Ceil Class Refactor:
Test Refactor:
clang-format -i --style=file path/to/your/file.java