Skip to content

refactor: improving MedianOfMatrix #6376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

alxkm
Copy link
Contributor

@alxkm alxkm commented Jul 13, 2025

  • Added a check to throw IllegalArgumentException if the input matrix contains no elements.
  • Prevents undefined behavior when computing median on empty data.
  • Ensures more robust and predictable method behavior.
  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • All new code is formatted with clang-format -i --style=file path/to/your/file.java

@codecov-commenter
Copy link

codecov-commenter commented Jul 13, 2025

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 74.63%. Comparing base (ef93cc1) to head (69bbb70).

Files with missing lines Patch % Lines
.../java/com/thealgorithms/matrix/MedianOfMatrix.java 85.71% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6376      +/-   ##
============================================
- Coverage     74.64%   74.63%   -0.01%     
  Complexity     5445     5445              
============================================
  Files           682      682              
  Lines         19000    19002       +2     
  Branches       3668     3670       +2     
============================================
+ Hits          14182    14183       +1     
  Misses         4260     4260              
- Partials        558      559       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants