-
Notifications
You must be signed in to change notification settings - Fork 20.2k
#6438 Improvement of Hamming Distance class #6447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#6438 Improvement of Hamming Distance class #6447
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6447 +/- ##
============================================
+ Coverage 75.04% 75.06% +0.01%
- Complexity 5534 5543 +9
============================================
Files 685 689 +4
Lines 19208 19219 +11
Branches 3706 3707 +1
============================================
+ Hits 14414 14426 +12
Misses 4239 4239
+ Partials 555 554 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
… not giving correct issues
I have tried resolving the formatting multiple times , but it seems each time I change the formatting it asks me to revert back the changes. Though there are no errors in here, only a formatting issue. Please give it a check once. |
Please install the clang-formatter locally, e.g. on linux |
Thank you for the help. @DenizAltunkapan |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contribution! |
Thank you for your contribution and the detailed implementation! While the Chain of Responsibility approach is technically sound and demonstrates good design principles, I think it introduces unnecessary complexity for this repository. The goal of the-algorithms/Java is to provide simple and easily understandable implementations of algorithms for learners. For HammingDistance, it is better to keep it as a single class with a static method, which makes it straightforward for beginners to understand and use. Thank you again for your effort and contribution! |
Issue #6438
I have created abstract class HammingHandler for managing various checks as per demanded in the issue raised. Also I have created additional test classes that would test the new classes created.
👍 I have read [CONTRIBUTING.md]
👍 This pull request is all my own work -- I have not plagiarized it.
👍 All filenames are in PascalCase.
👍 All functions and variable names follow Java naming conventions.
👍 All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
👍 All new code is formatted with
clang-format -i --style=file path/to/your/file.java