Skip to content

Fix devcontainer build failure #12837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Jul 9, 2025
Merged

Fix devcontainer build failure #12837

merged 12 commits into from
Jul 9, 2025
+97 −6

Conversation

bertrand-awz
Copy link
Contributor

Describe your change:

Fixes #12836

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@bertrand-awz bertrand-awz requested a review from cclauss as a code owner July 9, 2025 00:22
@algorithms-keeper
Copy link

Closing this pull request as invalid

@bertrand-awz, this pull request is being closed as the files submitted contains an invalid extension. This repository only accepts Python algorithms. Please read the Contributing guidelines first.

Invalid files in this pull request: .devcontainer/Dockerfile, .devcontainer/post_install.sh

@algorithms-keeper algorithms-keeper bot closed this Jul 9, 2025
@algorithms-keeper algorithms-keeper bot removed the request for review from cclauss July 9, 2025 00:22
@algorithms-keeper algorithms-keeper bot added the awaiting reviews This PR is ready to be reviewed label Jul 9, 2025
@bertrand-awz bertrand-awz mentioned this pull request Jul 9, 2025
Closed
@cclauss cclauss reopened this Jul 9, 2025
@cclauss
Copy link
Member

cclauss commented Jul 9, 2025

I reopened this for you to work on.

cclauss
cclauss reviewed Jul 9, 2025
View reviewed changes
@cclauss
Copy link
Member

cclauss commented Jul 9, 2025

Does this work? Should it be merged?

@cclauss cclauss self-requested a review July 9, 2025 05:34
@cclauss
Copy link
Member

cclauss commented Jul 9, 2025

@HManiac74 Your review, please.

@bertrand-awz
Copy link
Contributor Author

Does this work? Should it be merged?

Now, it's ok. Everything good !

cclauss
cclauss approved these changes Jul 9, 2025
View reviewed changes
Copy link
Member

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for doing this.

@cclauss cclauss merged commit ed7c9b5 into TheAlgorithms:master Jul 9, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss approved these changes

Assignees
No one assigned
Labels
awaiting reviews This PR is ready to be reviewed invalid
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Request to resolve build devcontainer failure
2 participants
@bertrand-awz @cclauss