Skip to content

Commit

Permalink
Fix language detection for files with dot in their names
Browse files Browse the repository at this point in the history
  • Loading branch information
9fcc committed Aug 24, 2018
1 parent 6f451ad commit 0590614
Show file tree
Hide file tree
Showing 3 changed files with 45 additions and 1 deletion.
4 changes: 3 additions & 1 deletion cmake/sanitize-helpers.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,9 @@

# Helper function to get the language of a source file.
function (sanitizer_lang_of_source FILE RETURN_VAR)
get_filename_component(FILE_EXT "${FILE}" EXT)
get_filename_component(LONGEST_EXT "${FILE}" EXT)
# Get shortest extension as some files can have dot in their names
string(REGEX REPLACE "^.*(\\.[^.]+)$" "\\1" FILE_EXT ${LONGEST_EXT})
string(TOLOWER "${FILE_EXT}" FILE_EXT)
string(SUBSTRING "${FILE_EXT}" 1 -1 FILE_EXT)

Expand Down
2 changes: 2 additions & 0 deletions tests/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -56,9 +56,11 @@ find_package(Sanitizers)
# add testcases
#
add_sanitized_testcase("asan_test_cpp" asan_test.cpp)
add_sanitized_testcase("shortest_ext_test_cpp" shortest.ext.test.cpp)

set_tests_properties(
"asan_test_cpp"
"shortest_ext_test_cpp"
PROPERTIES
WILL_FAIL TRUE
)
Expand Down
40 changes: 40 additions & 0 deletions tests/shortest.ext.test.cpp
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
/* This file is part of CMake-sanitizers.
*
* Permission is hereby granted, free of charge, to any person obtaining a copy
* of this software and associated documentation files (the "Software"), to deal
* in the Software without restriction, including without limitation the rights
* to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
* copies of the Software, and to permit persons to whom the Software is
* furnished to do so, subject to the following conditions:
*
* The above copyright notice and this permission notice shall be included in
* all copies or substantial portions of the Software.
*
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
* AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
* SOFTWARE.
*
*
* Copyright (c)
* 2013-2015 Matt Arsenault
* 2015 RWTH Aachen University, Federal Republic of Germany
*/


int
main(int argc, char **argv)
{
// Allocate a new array and delete it.
int *array = new int[argc + 1];
array[argc] = 0;
delete[] array;

/* Access element of the deleted array. This will cause an memory error with
* address sanitizer.
*/
return array[argc];
}

0 comments on commit 0590614

Please sign in to comment.