Skip to content

Commit

Permalink
thermal: revised Gimlet PID parameters
Browse files Browse the repository at this point in the history
Uses new offset parameter to avoid overshoot.
  • Loading branch information
mx-shift committed Nov 1, 2022
1 parent 811e38b commit dbaab18
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions task/thermal/src/bsp/gimlet_bc.rs
Original file line number Diff line number Diff line change
Expand Up @@ -163,10 +163,10 @@ impl Bsp {
pid_config: PidConfig {
// If we're > 10 degrees from the target temperature, fans
// should be on at full power.
zero: 0.0,
gain_p: 10.0,
gain_i: 0.5,
gain_d: 10.0,
zero: 35.0,
gain_p: 6.75,
gain_i: 0.17,
gain_d: 4.5,
},

inputs: &INPUTS,
Expand Down

0 comments on commit dbaab18

Please sign in to comment.