Skip to content

Commit

Permalink
[wpt] Fix misnamed tests that get HTTP 404
Browse files Browse the repository at this point in the history
`x.any.window.js` isn't a valid suffix [0] because it generates URLs
`x.window.any.html` and `x.window.any.worker.html`. This confuses
wptserve's extension substitution [1], which look for a nonexistent
file `x.window.any.js` (note the reversed order of the `.any` and
`.window` flags).

According to the PR [2] that introduced these tests, these should just
be plain `.window.js` tests.

`wpt lint` should ban such invalid flags in a follow-up PR upstream.

[0]: https://web-platform-tests.org/writing-tests/testharness.html
[1]: https://github.com/web-platform-tests/wpt/blob/e7b773cb/tools/serve/serve.py#L320
[2]: web-platform-tests#29765 (comment)

Bug: 1517496, 1499775
Change-Id: Ieac0c1e53a35d8f24df33bc44515af60bab210a3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5236256
Reviewed-by: Weizhong Xia <[email protected]>
Commit-Queue: Weizhong Xia <[email protected]>
Auto-Submit: Jonathan Lee <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1252164}
  • Loading branch information
jonathan-j-lee authored and chromium-wpt-export-bot committed Jan 25, 2024
1 parent 46c16b1 commit 0b23955
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 0 deletions.
File renamed without changes.
File renamed without changes.

0 comments on commit 0b23955

Please sign in to comment.