forked from web-platform-tests/wpt
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[basic-card] Migrate WPTs that use basic-card identifier
With basic card now disabled and soon to be removed, migrate web platform tests that test the payment method identifier syntax to use secure-payment-confirmation instead of basic-card. These tests pass either way, this is just to refresh the test data to a current feature. The merchant-validation test is also updated, in addition to the similar PMI validation change, it is updated to use an example URL payment method. Bug: 1209835 Change-Id: I109e9063720c21d10c5c0af1f765d553eaadeb83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3556267 Reviewed-by: Rouslan Solomakhin <[email protected]> Commit-Queue: Nick Burris <[email protected]> Cr-Commit-Position: refs/heads/main@{#986998}
- Loading branch information
1 parent
568dd14
commit 19cfa44
Showing
3 changed files
with
32 additions
and
32 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -16,8 +16,8 @@ | |
supportedNetworks: ["visa"], | ||
} | ||
}); | ||
const basicCard = Object.freeze({ supportedMethods: "basic-card" }); | ||
const defaultMethods = Object.freeze([basicCard, applePay]); | ||
const examplePay = Object.freeze({ supportedMethods: "https://example.com/pay" }); | ||
const defaultMethods = Object.freeze([examplePay, applePay]); | ||
const defaultDetails = Object.freeze({ | ||
total: { | ||
label: "Total", | ||
|
@@ -110,7 +110,7 @@ | |
"https://example.com/pay", | ||
"https://example.com/pay?version=1", | ||
"https://example.com/pay/version/1", | ||
"basic-card", | ||
"secure-payment-confirmation", | ||
"https://apple.com/apple-pay", | ||
// special case for as default value | ||
"", | ||
|
@@ -124,11 +124,11 @@ | |
test(() => { | ||
const invalidPMIs = [ | ||
// ❌ Contains Unicode character outside the valid ranges. | ||
"basic-💳", | ||
"secure-💳", | ||
// ❌ Contains uppercase characters. | ||
"Basic-Card", | ||
"Secure-Payment-Confirmation", | ||
// ❌ Contains Unicode characters outside the valid ranges. | ||
"¡basic-*-card!", | ||
"¡secure-*-payment-confirmation!", | ||
// ❌ Uses http://, a username, and a password. | ||
"http://username:[email protected]/pay", | ||
// ❌ Uses unknown URI scheme. | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters