Skip to content

Commit

Permalink
[HighlightPseudos] Fix tests on Mac
Browse files Browse the repository at this point in the history
The code for resolving highlight colors is updated to
use the correct previous_layer_color for non-Color
properties. The test was failing on Mac because
Mac does not have default theme selection colors.

Other tests have fuzzy matching added to account for
minor pixels diffs on Mac.

All expectations are updated.

Bug: 1433592,1351020
Change-Id: I9692704894615fd497832a133cc8e3f5b7655699
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4864002
Commit-Queue: Stephen Chenney <[email protected]>
Reviewed-by: Philip Rogers <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1198416}
  • Loading branch information
schenney-chromium authored and chromium-wpt-export-bot committed Sep 19, 2023
1 parent 1f0b247 commit 2a6425c
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
<link rel="help" href="https://drafts.csswg.org/css-pseudo/#highlight-text">
<link rel="match" href="highlight-currentcolor-painting-properties-001-ref.html">
<link rel="stylesheet" href="support/highlights.css">
<meta name="fuzzy" content="0-50;0-3">
<style>
div {
color: lime;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
<link rel="help" href="https://drafts.csswg.org/css-pseudo/#highlight-text">
<link rel="match" href="highlight-currentcolor-painting-properties-002-ref.html">
<link rel="stylesheet" href="support/highlights.css">
<meta name="fuzzy" content="0-50;0-3">
<style>
div {
color: lime;
Expand Down
1 change: 1 addition & 0 deletions css/css-pseudo/highlight-painting-003.html
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
<meta name="assert" value="::selection overlay background and decorations are independent of those of the originating element, and originating element decorations lose their colour">
<script src="support/selections.js"></script>
<link rel="stylesheet" href="support/highlights.css">
<meta name="fuzzy" content="0-50;0-50">
<style>
/*
Topmost last:
Expand Down
1 change: 1 addition & 0 deletions css/css-pseudo/highlight-painting-004.html
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
<meta name="assert" value="::selection overlay background and decorations are independent of those of the originating element, and originating element decorations lose their colour">
<script src="support/selections.js"></script>
<link rel="stylesheet" href="support/highlights.css">
<meta name="fuzzy" content="0-50;0-20">
<style>
/*
Topmost last:
Expand Down
1 change: 1 addition & 0 deletions forced-colors-mode/forced-colors-mode-53.html
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
<link rel="help" href="https://www.w3.org/TR/css-color-adjust-1/#forced-color-adjust-prop">
<link rel="help" href="https://drafts.csswg.org/css-highlight-api-1/">
<link rel=match href="forced-colors-mode-53-ref.html">
<meta name="fuzzy" content="0-5;0-3">
<style>
span {
background-color: lightgray;
Expand Down

0 comments on commit 2a6425c

Please sign in to comment.