Skip to content

Commit

Permalink
Implement URLPattern.hasRegExpGroups.
Browse files Browse the repository at this point in the history
This allows authors to tell whether a pattern contains one or more
regexp groups, which may limit the uses they're able to make of it.

Bug: 1504650
Change-Id: I07b684788e921448b60c4ffee9cfe87585a794c3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5054393
Reviewed-by: Shunya Shishido <[email protected]>
Commit-Queue: Jeremy Roman <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1228894}
  • Loading branch information
jeremyroman authored and chromium-wpt-export-bot committed Nov 24, 2023
1 parent 23dcf5b commit 2cc9ec1
Show file tree
Hide file tree
Showing 2 changed files with 20 additions and 0 deletions.
18 changes: 18 additions & 0 deletions urlpattern/resources/urlpattern-hasregexpgroups-tests.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
test(() => {
assert_implements('hasRegExpGroups' in URLPattern.prototype, "hasRegExpGroups is not implemented");
assert_false(new URLPattern({}).hasRegExpGroups, "match-everything pattern");
for (let component of ['protocol', 'username', 'password', 'hostname', 'port', 'pathname', 'search', 'hash']) {
assert_false(new URLPattern({[component]: '*'}).hasRegExpGroups, `wildcard in ${component}`);
assert_false(new URLPattern({[component]: ':foo'}).hasRegExpGroups, `segment wildcard in ${component}`);
assert_false(new URLPattern({[component]: ':foo?'}).hasRegExpGroups, `optional segment wildcard in ${component}`);
assert_true(new URLPattern({[component]: ':foo(hi)'}).hasRegExpGroups, `named regexp group in ${component}`);
assert_true(new URLPattern({[component]: '(hi)'}).hasRegExpGroups, `anonymous regexp group in ${component}`);
if (component !== 'protocol' && component !== 'port') {
// These components are more narrow in what they accept in any case.
assert_false(new URLPattern({[component]: 'a-{:hello}-z-*-a'}).hasRegExpGroups, `wildcards mixed in with fixed text and wildcards in ${component}`);
assert_true(new URLPattern({[component]: 'a-(hi)-z-(lo)-a'}).hasRegExpGroups, `regexp groups mixed in with fixed text and wildcards in ${component}`);
}
}
assert_false(new URLPattern({pathname: '/a/:foo/:baz?/b/*'}).hasRegExpGroups, "complex pathname with no regexp");
assert_true(new URLPattern({pathname: '/a/:foo/:baz([a-z]+)?/b/*'}).hasRegExpGroups, "complex pathname with regexp");
}, '');
2 changes: 2 additions & 0 deletions urlpattern/urlpattern-hasregexpgroups.any.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
// META: global=window,worker
// META: script=resources/urlpattern-hasregexpgroups-tests.js

0 comments on commit 2cc9ec1

Please sign in to comment.