Skip to content

Commit

Permalink
Make emptiness check for contenteditable also account for empty frames.
Browse files Browse the repository at this point in the history
Like abspos and other out of flows. Seems to match more what other browsers do.

Differential Revision: https://phabricator.services.mozilla.com/D73362

bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1634543
gecko-commit: b97ab5796dec6061b5689483ec2bc2371ba598f3
gecko-integration-branch: autoland
gecko-reviewers: jfkthame
  • Loading branch information
emilio authored and moz-wptsync-bot committed May 1, 2020
1 parent 795e198 commit 380be22
Show file tree
Hide file tree
Showing 2 changed files with 30 additions and 0 deletions.
9 changes: 9 additions & 0 deletions contenteditable/synthetic-height-ref.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
<!doctype html>
<title>CSS test reference</title>
<style>
div { background: green; border: 1px solid; }
</style>
<div><br></div>
<div><br></div>
<div><br></div>
<div><br></div>
21 changes: 21 additions & 0 deletions contenteditable/synthetic-height.tentative.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
<!doctype html>
<title>contenteditable causes blocks to have a synthesized height</title>
<link rel="author" href="mailto:[email protected]" title="Emilio Cobos Álvarez">
<link rel="author" href="https://mozilla.org" title="Mozilla">
<link rel="help" href="https://bugzilla.mozilla.org/show_bug.cgi?id=1098151">
<link rel="help" href="https://bugzilla.mozilla.org/show_bug.cgi?id=1634543">
<link rel="help" href="https://github.com/w3c/editing/issues/70">
<link rel="match" href="synthetic-height-ref.html">
<style>
div { background: green; border: 1px solid; }
.pseudo::before {
content: "";
}
.abspos-pseudo::before {
position: absolute;
}
</style>
<div contenteditable></div>
<div contenteditable><span style="position: absolute"></span></div>
<div contenteditable class="pseudo"></div>
<div contenteditable class="pseudo abspos-pseudo"></div>

0 comments on commit 380be22

Please sign in to comment.