Skip to content

Commit

Permalink
FSA: Use IDL-generated string constants for WellKnownDirectory
Browse files Browse the repository at this point in the history
Follow-up to https://crrev.com/c/4727474 which addresses use of the
WellKnownDirectory enum. Also refectors the mojom interface to simplify
the file picker options passed over mojo

By removing the kDefault option from the WellKnownDirectory mojom enum,
it now matches its counterpart defined in web IDL

Fixed: 1470285
Change-Id: I84d513a621b0f55cabff12d95c4037a93adc27ee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4736693
Commit-Queue: Mustafa Emre Acer <[email protected]>
Reviewed-by: Nathan Memmott <[email protected]>
Reviewed-by: Mustafa Emre Acer <[email protected]>
Auto-Submit: Austin Sullivan <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1181083}
  • Loading branch information
a-sully authored and chromium-wpt-export-bot committed Aug 8, 2023
1 parent b7b63a9 commit 4817e8c
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions file-system-access/showPicker-errors.https.window.js
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,12 @@ function define_file_picker_error_tests(showPickerMethod) {
}));
}, showPickerMethod + ': unknown well-known starting directory.');

promise_test(async t => {
await promise_rejects_js(t, TypeError, self[showPickerMethod]({
startIn: '',
}));
}, showPickerMethod + ': starting directory can\t be empty.');

promise_test(async t => {
await promise_rejects_js(t, TypeError, self[showPickerMethod]({
startIn: null,
Expand Down

0 comments on commit 4817e8c

Please sign in to comment.