Skip to content

Commit

Permalink
[Web Payment] Disable PaymentInstruments
Browse files Browse the repository at this point in the history
This patch disables the PaymentInstruments API
(paymentManager.instruments) and removes IDL harness expectations for
it. It does not, however, remove the feature code itself, as that will
be a separate patch.

Intent to deprecate and remove:
https://groups.google.com/a/chromium.org/g/blink-dev/c/VenSGqBIoKI/m/HGyofbCGCAAJ

Chrome status:
https://chromestatus.com/feature/5099285054488576

Bug: 1327265
Change-Id: I32e9bdb65648d145ccde4ed71a2e49b47fee77ea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4067199
Commit-Queue: Rouslan Solomakhin <[email protected]>
Reviewed-by: Nate Fischer <[email protected]>
Reviewed-by: Rick Byers <[email protected]>
Reviewed-by: Stephen McGruer <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1096753}
  • Loading branch information
rsolomakhin authored and chromium-wpt-export-bot committed Jan 25, 2023
1 parent 5b86752 commit 57eddd9
Show file tree
Hide file tree
Showing 5 changed files with 0 additions and 433 deletions.
23 changes: 0 additions & 23 deletions interfaces/payment-handler.idl
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ partial interface ServiceWorkerRegistration {

[SecureContext, Exposed=(Window,Worker)]
interface PaymentManager {
[SameObject] readonly attribute PaymentInstruments instruments;
attribute DOMString userHint;
Promise<undefined> enableDelegations(sequence<PaymentDelegation> delegations);
};
Expand All @@ -21,28 +20,6 @@ enum PaymentDelegation {
"payerEmail"
};

[SecureContext, Exposed=(Window,Worker)]
interface PaymentInstruments {
Promise<boolean> delete(DOMString instrumentKey);
Promise<any> get(DOMString instrumentKey);
Promise<sequence<DOMString>> keys();
Promise<boolean> has(DOMString instrumentKey);
Promise<undefined> set(DOMString instrumentKey, PaymentInstrument details);
Promise<undefined> clear();
};

dictionary PaymentInstrument {
required DOMString name;
sequence<ImageObject> icons;
DOMString method;
};

dictionary ImageObject {
required USVString src;
DOMString sizes;
DOMString type;
};

partial interface ServiceWorkerGlobalScope {
attribute EventHandler oncanmakepayment;
};
Expand Down
2 changes: 0 additions & 2 deletions payment-handler/idlharness.https.any.js
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ idl_test(
idl_array.add_objects({
ServiceWorkerRegistration: ['registration'],
PaymentManager: ['paymentManager'],
PaymentInstruments: ['instruments'],
});
}
if (isServiceWorker) {
Expand All @@ -41,7 +40,6 @@ idl_test(
}
if (hasRegistration) {
self.paymentManager = self.registration.paymentManager;
self.instruments = self.paymentManager.instruments;
}
}
);
Loading

0 comments on commit 57eddd9

Please sign in to comment.