Skip to content

Commit

Permalink
Allow 'transform' to be 'none' while animating.
Browse files Browse the repository at this point in the history
This allows the computed value of 'transform' to be 'none' while the
transform property is animating, or while one of the independent
transform properties is set, or while offset-position or offset-path are
used.

This depends on the previous patch to avoid having the
transitions-specific bug fixed there cause new failures in
transform-interpolation-00{1,2,5,6}.html .

Fixed: 897358
Change-Id: I9ac00024a2497684e00a0407c59d357a5ab77e43
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3198752
Commit-Queue: David Baron <[email protected]>
Reviewed-by: Rune Lillesveen <[email protected]>
Cr-Commit-Position: refs/heads/main@{#927466}
  • Loading branch information
dbaron authored and chromium-wpt-export-bot committed Oct 2, 2021
1 parent 2987fa6 commit 955f430
Showing 1 changed file with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@
);
animation.play();
await waitForAsyncAnimationFrames(1);
assert_equals(getComputedStyle(target).transform, "matrix(1, 0, 0, 1, 0, 0)");
assert_equals(getComputedStyle(target).transform, "none");
}, "A worklet which never sets localTime has no effect.");

promise_test(async t => {
Expand All @@ -72,7 +72,7 @@
);
animation.play();
await waitForAsyncAnimationFrames(1);
assert_equals(getComputedStyle(target).transform, "matrix(1, 0, 0, 1, 0, 0)");
assert_equals(getComputedStyle(target).transform, "none");
}, "A worklet which sets localTime to null has no effect.");

promise_test(async t => {
Expand Down Expand Up @@ -112,7 +112,7 @@

await waitForAnimationFrameWithCondition(() => animation.currentTime > 1000);
await waitForAsyncAnimationFrames(1);
assert_equals(getComputedStyle(target).transform, "matrix(1, 0, 0, 1, 0, 0)",
assert_equals(getComputedStyle(target).transform, "none",
"The effect stops on nulling of localTime");

}, "A worklet which changes localTime to from a number to null has no effect on transform.");
Expand Down

0 comments on commit 955f430

Please sign in to comment.