Skip to content

Commit

Permalink
Remove direct-sockets- prefix from direct sockets WPT file names
Browse files Browse the repository at this point in the history
Presubmit is blocking the submission of some expectation files related
to these tests because the file name is too long for Windows. The file
path has semantic meaning so the only option I can see for reducing the
path length is renaming the tests, and the direct-socket- prefix seemed
like a good candidate as these files are in a direct-sockets/ folder.

The problematic expectation file would be in:
third_party/blink/web_tests/flag-specific/disable-site-isolation-trials
followed by the full path to the test, which combined is over the 200
character path limit we enforce for Windows.

Bug: 1333966
Change-Id: Ia26a516b4cfea40e59e58aa92415ad4aea5e9a48
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4077065
Reviewed-by: Andrew Rayskiy <[email protected]>
Commit-Queue: Andrew Rayskiy <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1079153}
  • Loading branch information
robbiemc authored and chromium-wpt-export-bot committed Dec 5, 2022
1 parent d994afb commit d870c59
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,6 @@
<script src="/resources/testdriver-vendor.js"></script>
</head>
<body>
<script src="direct-sockets-disabled-by-permissions-policy.js"></script>
<script src="disabled-by-permissions-policy.js"></script>
</body>
</html>

0 comments on commit d870c59

Please sign in to comment.