Fix timeout in svg-mouse-listener a11y test

The recommended approach to make a crash test asynchronous is to use reftest-wait. Unfortunately, test-driver does not work with ref-tests. The fix is to pull the test out of crashtests and author as a promise test. This is the only a11y crash test that uses test-driver, and thus, the only one that is affected. The test needs to be asynchronous to avoid a memory leak. The reason is due to the fact that we have armed an event listener that is never triggered unless we wait. A crash-test only waits until onload is complete. Bug: 328403023 Change-Id: If33410bd498995b8216e805c8edc27c093e3db1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5348198 Reviewed-by: Aaron Leventhal <[email protected]> Commit-Queue: Kevin Ellis <[email protected]> Cr-Commit-Position: refs/heads/main@{#1269156}
Tobias710219 · Mar 6, 2024 · fcb1f27 · fcb1f27
1 parent fae30e9
commit fcb1f27
Show file tree

Hide file tree

Showing 2 changed files with 34 additions and 19 deletions.
diff --git a/accessibility/crashtests/svg-mouse-listener.html b/accessibility/crashtests/svg-mouse-listener.html
diff --git a/accessibility/svg-mouse-listener.html b/accessibility/svg-mouse-listener.html
@@ -0,0 +1,34 @@
+<!DOCTYPE html>
+<html>
+<script src="/resources/testharness.js"></script>
+<script src="/resources/testharnessreport.js"></script>
+<script src="/resources/testdriver.js"></script>
+<script src="/resources/testdriver-vendor.js"></script>
+<script src="/resources/testdriver-actions.js"></script>
+<svg viewBox="0 0 500 500">
+    <rect width="500" height="500" id="target" fill="red">
+</svg>
+
+<script>
+function clickPromise() {
+  return new Promise(resolve => {
+    document.getElementById("target").addEventListener("click", resolve,
+                                                       { once: true });
+  });
+}
+
+// While the other accessibility tests are crash-tests, this one cannot be
+// authored as one. The reason is that a crash-test is complete when a onload
+// is complete. The recommended strategy for supporting asynchronous testing
+// is to use reftest wait. Unfortunately, reftests are not compatible with
+// test-driver. The test needs to be asynchronous as unless we wait for the
+// click to be handled, we are not giving the browser a chance to crash. In
+// addition the lack of a wait triggers detection of a memory leak in Blink.
+promise_test(async () => {
+  const click_promise = clickPromise();
+  await test_driver.click(document.body);
+  return click_promise;
+}, 'Clicking SVG element does not crash the browser');
+
+</script>
+</html>