Adds a plist strategy (pointfreeco#73)

* Support plist snapshots. * update snaps * revert snaps * guard for linux * better guard for linux
TomHumphrey150 · Nov 2, 2018 · ff2d53f · ff2d53f
1 parent 00bdf92
commit ff2d53f
Show file tree

Hide file tree

Showing 5 changed files with 38 additions and 3 deletions.
diff --git a/Sources/SnapshotTesting/Strategy/Codable.swift b/Sources/SnapshotTesting/Strategy/Codable.swift
@@ -1,6 +1,6 @@
 import Foundation
 
-extension Strategy where A: Encodable {
+extension Strategy where A: Encodable, B == String {
   @available(OSX 10.13, *)
   public static var json: Strategy<A, String> {
     let encoder = JSONEncoder()
@@ -9,8 +9,26 @@ extension Strategy where A: Encodable {
   }
 
   public static func json(_ encoder: JSONEncoder) -> Strategy<A, String> {
-    return Strategy.lines.pullback { encodable in
+    var strategy = Strategy.lines.pullback { (encodable: A) in
       try! String(decoding: encoder.encode(encodable), as: UTF8.self)
     }
+    strategy.pathExtension = "json"
+    return strategy
   }
+
+  #if !os(Linux)
+  public static var plist: Strategy<A, String> {
+    let encoder = PropertyListEncoder()
+    encoder.outputFormat = .xml
+    return .plist(encoder)
+  }
+
+  public static func plist(_ encoder: PropertyListEncoder) -> Strategy<A, String> {
+    var strategy = Strategy.lines.pullback { (encodable: A) in
+      try! String(decoding: encoder.encode(encodable), as: UTF8.self)
+    }
+    strategy.pathExtension = "plist"
+    return strategy
+  }
+  #endif
 }
diff --git a/Tests/SnapshotTestingTests/SnapshotTestingTests.swift b/Tests/SnapshotTestingTests/SnapshotTestingTests.swift
@@ -34,9 +34,14 @@ class SnapshotTestingTests: SnapshotTestCase {
 
   func testWithEncodable() {
     struct User: Encodable { let id: Int, name: String, bio: String }
+    let user = User(id: 1, name: "Blobby", bio: "Blobbed around the world.")
 
     if #available(OSX 10.13, *) {
-      assertSnapshot(of: .json, matching: User(id: 1, name: "Blobby", bio: "Blobbed around the world."))
+      assertSnapshot(of: .json, matching: user)
+
+      #if !os(Linux)
+      assertSnapshot(of: .plist, matching: user)
+      #endif
     }
   }
 

diff --git a/Tests/SnapshotTestingTests/__Snapshots__/SnapshotTestingTests/testNSView.1.png b/Tests/SnapshotTestingTests/__Snapshots__/SnapshotTestingTests/testNSView.1.png
diff --git a/...pshotTestingTests/testWithEncodable.1.txt → ...shotTestingTests/testWithEncodable.1.json b/...pshotTestingTests/testWithEncodable.1.txt → ...shotTestingTests/testWithEncodable.1.json
diff --git a/Tests/SnapshotTestingTests/__Snapshots__/SnapshotTestingTests/testWithEncodable.2.plist b/Tests/SnapshotTestingTests/__Snapshots__/SnapshotTestingTests/testWithEncodable.2.plist
@@ -0,0 +1,12 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
+<plist version="1.0">
+<dict>
+	<key>bio</key>
+	<string>Blobbed around the world.</string>
+	<key>id</key>
+	<integer>1</integer>
+	<key>name</key>
+	<string>Blobby</string>
+</dict>
+</plist>