[pull] master from MidnightCommander:master #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
When tar data block unexpected end then header_copy get freed but "goto ret:" freed header_copy again. Do not free header_copy at exit from the loop of reading tar blocks. Found by Clang-19 Static Analyzer. The bug was introduced in 8223f82. Reported-by: Andreas Mohr <[email protected]> Signed-off-by: Andrew Borodin <[email protected]>
* 4616_tar_double_free: Ticket #4616: (tar_read_header): fix double free.
…r-free. Fix Use-after-free in sftpfs_fill_connection_data_from_config() Found by Clang-19 Static Analyzer The bug was introduced in 4c998ac. Reported-by: Andreas Mohr <[email protected]> Signed-off-by: Andrew Borodin <[email protected]>
src/filemanager/hotlist.c:1046:26: warning: Use of memory after it is freed [clang-analyzer-unix.Malloc]
1046 | if (title == NULL || *title == '\0' || url == NULL || *url == '\0')
| ^~~~~~
- distinct def_text and title/url
- simplify and move quick_dialog return evaluation in same function add_new_entry_cmd()
Found by Clang-19 Static Analyzer.
Signed-off-by: Andreas Mohr <[email protected]>
Signed-off-by: Andrew Borodin <[email protected]>
* 4620_use_after_free: Ticket #5621: (add_new_entry_cmd): fix Use-after-free. Ticket #4620: (sftpfs_fill_connection_data_from_config): fix use-after-free.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.1)
Can you help keep this open source service alive? 💖 Please sponsor : )