fix: ShadCN/Ariakit AI menu #1688
Open
+283
−100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
YousefED
reviewed
May 16, 2025
|
|
||
| assertEmpty(rest); | ||
|
|
||
| return ( | ||
| <div className={className} ref={ref}> | ||
| {children} | ||
| <svg |
There was a problem hiding this comment.
did you copy this from anywhere? in that case always good to leave the source url as a comment
| } else if (aiResponseStatus === "error") { | ||
| return ( | ||
| <div className={"bn-combobox-right-section bn-combobox-error"}> | ||
| <span>!</span> |
There was a problem hiding this comment.
this ! is selectable, which is a bit weird. Also, maybe there are nicer icons for this?
| @@ -3,6 +3,9 @@ export const en = { | |||
| ai: { | |||
| tooltip: "Generate content", | |||
| input_placeholder: "Enter a prompt", | |||
| thinking: "Thinking", | |||
| editing: "Editing", | |||
| error: "An error has occurred", | |||
There was a problem hiding this comment.
can you also remove unused items from the dictionaries? like ai_block
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rightSectionprop to inputs