Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tsm 24 #27

Merged
merged 3 commits into from
Oct 14, 2022
Merged

Tsm 24 #27

merged 3 commits into from
Oct 14, 2022

Conversation

LironHazan
Copy link
Collaborator

@LironHazan LironHazan commented Oct 14, 2022

Changes:

  1. I removed yarn leftovers in order to avoid different package managers errors - we use npm lock file so I aligned to that, alternatively we can use pnpm/yarn (or even bun as a package manager, I have good experience with it) in future if we'll like but its not a large project so no actual need..
  2. I added another transparent layer of dist/ts-mockito in order to publish from that (from CI as well), this preserves the older structure but as part of a "better" practice.
    image
  3. I added some more npm utility scripts, maybe worth having a separate script for building in future..
  4. ** Added the publish to npm gha

@codecov
Copy link

codecov bot commented Oct 14, 2022

Codecov Report

Merging #27 (86d7c21) into master (281d8d6) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #27   +/-   ##
=======================================
  Coverage   94.58%   94.58%           
=======================================
  Files          34       34           
  Lines         665      665           
  Branches       83       83           
=======================================
  Hits          629      629           
  Misses         32       32           
  Partials        4        4           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link

@mikeporterdev mikeporterdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will close #25 in favour of this :)

@LironHazan LironHazan merged commit 84354f7 into TypeStrong:master Oct 14, 2022
LironHazan added a commit to LironHazan/ts-mockito that referenced this pull request Oct 14, 2022
Merge pull request TypeStrong#27 from LironHazan/tsm-24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants