Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruin formatting #354

Closed
wants to merge 1 commit into from
Closed

Ruin formatting #354

wants to merge 1 commit into from

Conversation

96-LB
Copy link

@96-LB 96-LB commented Feb 3, 2025

Your code was looking a little too clean, so I decided to mess it up a bit.

@Tyrrrz Tyrrrz added the format label Feb 3, 2025
Copy link

codecov bot commented Feb 3, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 95.83%. Comparing base (dd046c3) to head (146e141).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
LightBulb.Core/ColorConfiguration.cs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #354      +/-   ##
==========================================
- Coverage   96.35%   95.83%   -0.53%     
==========================================
  Files           7        7              
  Lines         192      192              
  Branches       15       15              
==========================================
- Hits          185      184       -1     
- Misses          6        7       +1     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tyrrrz
Copy link
Owner

Tyrrrz commented Feb 3, 2025

Thanks for helping @96-LB. I've come to the conclusion that the overhead required to get it working for external forks is not really worth the benefit.

@Tyrrrz Tyrrrz closed this Feb 3, 2025
@Tyrrrz Tyrrrz reopened this Feb 3, 2025
@Tyrrrz Tyrrrz closed this Feb 3, 2025
@Tyrrrz Tyrrrz reopened this Feb 3, 2025
@Tyrrrz Tyrrrz closed this Feb 3, 2025
@Tyrrrz Tyrrrz reopened this Feb 3, 2025
@Tyrrrz Tyrrrz closed this Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants