Add HookEngineTick setting and EngineTick as GUI RenderMode #794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: Implement new RenderMode -> EngineTick refactor: Changed gui_render_thread_GameViewportClientTick to gui_render_thread_tick, to be a generic function that can be used in all Tick function hooks
igromanru
force-pushed
the
rendermode_engine_tick
branch
from
7942e42 to
a634119
Compare
UE4SS
requested changes
Feb 18, 2025
UE4SS
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Similar to #768 where
GameViewportClientTickwas added as a newRenderModefor the GUI Tool, I've addedEngineTick.Additionally, I had to add
HookEngineTicksetting, as it wasn't a thing yet.I put
EngineTickeverywhere in front ofGameViewportClientTickbecause I think it's more important. GameViewportClient doesn't exist on servers and with Engine::Tick implementation the hook might be obsolete in the future.How it was tested
After setting
RenderMode = EngineTick, I attached the debugger to the game at the start and made sure thatEngine::Tickis used instead ofGameViewportClient::Tick.Then I played around in the Live View like before and it worked well. At least as good as it usually works.
Additionally, I tested it in Dedicated Server and unlike
GameViewportClientTickit works there as well! 🥳The game in question is Abiotic Factor.