test_equivalence instead of test_equal

When comparing different tables, sometimes despite the tables being identical, test_equal still returns false. Use test_equivalence instead.
UNSW-CEEM · Jul 27, 2023 · 421bf99 · 421bf99
1 parent fe7c642
commit 421bf99
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 9 deletions.
diff --git a/reconnect_compliance/tests/test_create_reconnection_summary.R b/reconnect_compliance/tests/test_create_reconnection_summary.R
@@ -44,7 +44,7 @@ testthat::test_that("Categorising a circuit with 5s data, and just a breif ramp
                                                     ramp_rate_change_resource_limit_threshold = -0.1)
 
 
-  testthat::expect_equal(calculated_results, expected_results, tolerance = 1e-4)
+  testthat::expect_equivalence(calculated_results, expected_results, tolerance = 1e-4)
 })
 
 
@@ -82,7 +82,7 @@ testthat::test_that("Categorising a circuit with 5s data, sustained ramp rate vi
                                                     ramp_threshold_for_non_compliance = 0.3,
                                                     ramp_rate_change_resource_limit_threshold = -0.1)
 
-  testthat::expect_equal(calculated_results, expected_results, tolerance = 1e-4)
+  testthat::expect_equivalence(calculated_results, expected_results, tolerance = 1e-4)
 })
 
 
@@ -120,7 +120,7 @@ testthat::test_that("Categorising a circuit with 60s data, no ramp rate violatio
                                                     ramp_threshold_for_non_compliance = 0.3,
                                                     ramp_rate_change_resource_limit_threshold = -0.1)
 
-  testthat::expect_equal(calculated_results, expected_results, tolerance = 1e-4)
+  testthat::expect_equivalence(calculated_results, expected_results, tolerance = 1e-4)
 })
 
 
@@ -159,5 +159,5 @@ testthat::test_that("Categorising a circuit with 5s data, sustained ramp rate vi
                                                     ramp_rate_change_resource_limit_threshold = -0.1)
 
 
-  testthat::expect_equal(calculated_results, expected_results, tolerance = 1e-4)
-})
+  testthat::expect_equivalence(calculated_results, expected_results, tolerance = 1e-4)
+})
diff --git a/reconnect_compliance/tests/test_reconnection_time_calculation.R b/reconnect_compliance/tests/test_reconnection_time_calculation.R
@@ -46,5 +46,5 @@ testthat::test_that("Calculating reconnection times works",{
   calculated_reconnection_times <- calculate_reconnection_times(normalised_power, event_time, 
                                                                 disconnect_threshold = 0.05, reconnect_threshold = 0.95)
 
-  testthat::expect_equal(calculated_reconnection_times, expected_reconnection_times, tolerance = 1e-4)
-})
+  testthat::expect_equivalence(calculated_reconnection_times, expected_reconnection_times, tolerance = 1e-4)
+})
diff --git a/upscale_disconnections/tests/test_summarise_disconnections.R b/upscale_disconnections/tests/test_summarise_disconnections.R
@@ -31,7 +31,7 @@ testthat::test_that("group_disconnections_by_manufacturer",{
   circuit_summary <- load_test_file(circuit_summary)
   expected_output <- load_test_file(expected_output)
   output <- group_disconnections_by_manufacturer(circuit_summary)
-  testthat::expect_equal(output, expected_output, tolerance = 1e-4)
+  testthat::expect_equivalence(output, expected_output, tolerance = 1e-4)
 })
 
 testthat::test_that("join_circuit_summary_and_cer_manufacturer_data",{

diff --git a/upscale_disconnections/tests/test_summarise_disconnections_excluding_ufls.R b/upscale_disconnections/tests/test_summarise_disconnections_excluding_ufls.R
@@ -31,7 +31,7 @@ testthat::test_that("group_disconnections_by_manufacturer",{
   circuit_summary <- load_test_file(circuit_summary)
   expected_output <- load_test_file(expected_output)
   output <- group_disconnections_by_manufacturer(circuit_summary, exclude_ufls_circuits = TRUE)
-  testthat::expect_equal(output, expected_output, tolerance = 1e-4)
+  testthat::expect_equivalence(output, expected_output, tolerance = 1e-4)
 })
 
 testthat::test_that("get_number_of_ufls_disconnections",{