Fix ADDJOB MAXLEN off-by-one error

fixes antirez#109
Under-soil · Aug 10, 2015 · 4ef6b01 · 4ef6b01
1 parent 6dbfa4c
commit 4ef6b01
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/src/job.c b/src/job.c
@@ -1135,7 +1135,7 @@ void addjobCommand(client *c) {
 
     /* If maxlen was specified, check that the local queue len is
      * within the requested limits. */
-    if (maxlen && queueNameLength(c->argv[1]) > (unsigned long) maxlen) {
+    if (maxlen && queueNameLength(c->argv[1]) >= (unsigned long) maxlen) {
         addReplySds(c,
             sdsnew("-MAXLEN Queue is already longer than "
                    "the specified MAXLEN count\r\n"));

diff --git a/tests/cluster/tests/03-jobs-queueing.tcl b/tests/cluster/tests/03-jobs-queueing.tcl
@@ -117,3 +117,10 @@ test "Single node jobs are correctly ordered in a FIFO fashion" {
         assert {$body == $j}
     }
 }
+
+test "ADDJOB fails if queue length exceeds MAXLEN" {
+    set qname [randomQueue]
+    D 0 addjob $qname myjob 5000 maxlen 1
+    catch {D 0 addjob $qname myjob 5000 maxlen 1} job_id
+    assert_match {MAXLEN*} $job_id
+}