Add missing entry to Android proguard #333
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
todi1856
approved these changes
Apr 29, 2025
IGuscin
approved these changes
Apr 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.unity3d.com/browse/MNB-90
Proguard entry for NotificationChannelWrapper was not present, hence this class is not prevented from being minified/obfuscated, even though it is being used from C# and obfuscation should be disabled for it. There were no issues in the past, but likely with Android tools updated, being non-public, the class got obfuscated and C# code is no longer able to retrieve channel details.
The issue happens with Release builds. The exception shows that class gets renamed to a single-letter and it's fields are not found either due to renames to single letter names too.
Only tested trunk on a single device, as this bug is build-time (hence Android version or device are irrelevant). Unity version is only relevant with regard that in the past the class was preserved even without explicit rule present (Android tools). The added rule is correct regardless.