Skip to content

Commit

Permalink
storegateway: Use prometheus.NewDesc in tests (grafana#6203)
Browse files Browse the repository at this point in the history
With prometheus/client_golang v1.17 these tests segfault, due to lacking prometheus.Desc initialization.

Signed-off-by: Arve Knudsen <[email protected]>
  • Loading branch information
aknuds1 authored Oct 3, 2023
1 parent 6c77e27 commit 4023aee
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions pkg/storegateway/bucket_e2e_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -977,7 +977,7 @@ func numObservationsForSummaries(t *testing.T, summaryName string, metrics dskit
summaryData.AddSummary(metric.GetSummary())
}
m := &dto.Metric{}
require.NoError(t, summaryData.Metric(&prometheus.Desc{}).Write(m))
require.NoError(t, summaryData.Metric(prometheus.NewDesc("test", "", nil, nil)).Write(m))
return m.GetSummary().GetSampleCount()
}

Expand All @@ -989,6 +989,6 @@ func numObservationsForHistogram(t *testing.T, histogramName string, metrics dsk
histogramData.AddHistogram(metric.GetHistogram())
}
m := &dto.Metric{}
require.NoError(t, histogramData.Metric(&prometheus.Desc{}).Write(m))
require.NoError(t, histogramData.Metric(prometheus.NewDesc("test", "", nil, nil)).Write(m))
return m.GetHistogram().GetSampleCount()
}

0 comments on commit 4023aee

Please sign in to comment.