[checkpoint] Log error when fork (MystenLabs#5271)

VOKA-AI · Oct 17, 2022 · 74180e5 · 74180e5
1 parent ab99c73
commit 74180e5
Showing 1 changed file with 16 additions and 4 deletions.
diff --git a/crates/sui-core/src/checkpoints/mod.rs b/crates/sui-core/src/checkpoints/mod.rs
@@ -775,10 +775,22 @@ impl CheckpointStore {
         committee: &Committee,
     ) -> SuiResult {
         checkpoint.verify(committee, None)?;
-        debug_assert!(matches!(
-            self.latest_stored_checkpoint(),
-            Some(AuthenticatedCheckpoint::Signed(_))
-        ));
+        match self.latest_stored_checkpoint() {
+            Some(AuthenticatedCheckpoint::Signed(s)) => {
+                if s.summary != checkpoint.summary {
+                    error!(
+                        cp_seq=checkpoint.summary.sequence_number,
+                        "Local signed checkpoint is not the same as the checkpoint cert. Most likely local checkpoint has forked. cert: {}, local signed: {}",
+                        checkpoint.summary,
+                        s.summary,
+                    );
+                    panic!();
+                }
+            }
+            _ => {
+                unreachable!("Can never call promote_signed_checkpoint_to_cert when there is no signed checkpoint locally");
+            }
+        }
         let seq = checkpoint.summary.sequence_number();
         self.tables
             .checkpoints