Skip to content

Commit

Permalink
Update example to comply with = for default parameters. (#902)
Browse files Browse the repository at this point in the history
* Update example to comply with = for default parameters.

Previously stated rule: https://www.dartlang.org/guides/language/effective-dart/usage#do-use--to-separate-a-named-parameter-from-its-default-value

* Update good_design.dart to use = for default params.
  • Loading branch information
johnsonmh authored and chalin committed Jun 4, 2018
1 parent 5732cff commit 142ba67
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 12 deletions.
12 changes: 6 additions & 6 deletions examples/misc/lib/effective_dart/design_good.dart
Original file line number Diff line number Diff line change
Expand Up @@ -471,12 +471,12 @@ class DateTime0 {
class Duration0 {
// #docregion omit-optional-positional
Duration0(
{int days: 0,
int hours: 0,
int minutes: 0,
int seconds: 0,
int milliseconds: 0,
int microseconds: 0});
{int days = 0,
int hours = 0,
int minutes = 0,
int seconds = 0,
int milliseconds = 0,
int microseconds = 0});
// #enddocregion omit-optional-positional
}

Expand Down
12 changes: 6 additions & 6 deletions src/_guides/language/effective-dart/design.md
Original file line number Diff line number Diff line change
Expand Up @@ -1682,12 +1682,12 @@ DateTime(int year,
int microsecond = 0]);

Duration(
{int days: 0,
int hours: 0,
int minutes: 0,
int seconds: 0,
int milliseconds: 0,
int microseconds: 0});
{int days = 0,
int hours = 0,
int minutes = 0,
int seconds = 0,
int milliseconds = 0,
int microseconds = 0});
{% endprettify %}


Expand Down

0 comments on commit 142ba67

Please sign in to comment.