DefaultFactory#create(Class<T>):

Simplified normal instantiation
Vampire · Dec 15, 2021 · 4e06c96 · 4e06c96
1 parent 10ce657
commit 4e06c96
Showing 1 changed file with 3 additions and 5 deletions.
diff --git a/src/main/java/picocli/CommandLine.java b/src/main/java/picocli/CommandLine.java
@@ -5505,12 +5505,10 @@ public <T> T create(Class<T> cls) throws Exception {
                     return cls.cast(new LinkedHashMap<Object, Object>());
                 }
             }
+            Constructor<T> constructor = cls.getDeclaredConstructor();
             try {
-                @SuppressWarnings("deprecation") // Class.newInstance is deprecated in Java 9
-                T result = cls.newInstance();
-                return result;
-            } catch (Exception ex) {
-                Constructor<T> constructor = cls.getDeclaredConstructor();
+                return constructor.newInstance();
+            } catch (IllegalAccessException ex) {
                 constructor.setAccessible(true);
                 return constructor.newInstance();
             }