Add alerting rules for operator (#526) #828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Amper
force-pushed
the
issue-526-alerting-rules
branch
from
a5d7fb0 to
00f92c5
Compare
Amper
force-pushed
the
issue-526-alerting-rules
branch
2 times, most recently
from
009c3b3 to
0525e13
Compare
Amper
force-pushed
the
issue-526-alerting-rules
branch
from
0525e13 to
18f9d77
Compare
Haleygo
reviewed
Dec 22, 2023
| expr: sum(rate(operator_log_messages_total{level="error", job=~".*((victoria.*)|vm)-?operator"}[5m])) > 0 | ||
| for: 15m | ||
| labels: | ||
| severity: high |
There was a problem hiding this comment.
Should we use the same set of severity like other VictoriaMetrics rules here, like "critical"?
There was a problem hiding this comment.
I don't think that it's critical, because it doesn't directly affect the deployments and monitoring work, but you are right, we have to use the same severity names. Maybe change to warning, wdyt? (+ @f41gh7)
f41gh7
reviewed
Dec 22, 2023
| dashboard: "{{ $externalURL }}/d/1H179hunk/victoriametrics-operator?ds={{ $labels.dc }}&orgId=1&viewPanel=10" | ||
| summary: "Too many errors at reconcile loop of operator: {{ $value}}" | ||
| - alert: HighQueueDepth | ||
| expr: (sum(workqueue_depth{job=~".*((victoria.*)|vm)-?operator"}) by (name)) > 10 |
There was a problem hiding this comment.
Based on my experience, workqueue_depth for vmuser and vmalertmanager config can be slow and trigger given alert. I propose to exclude it from matching.
vmuser reconcile is slow because of additional secret creation. The same for alertmanagerconfig
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#526