fix(contracts): OZ-N08 Deprecated Variables Are Still Being Assigned …

…Values (#1099) Co-authored-by: Péter Garamvölgyi <[email protected]>
Vineetkg20 · Feb 5, 2024 · 132657d · 132657d
1 parent 4371fa9
commit 132657d
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 6 deletions.
diff --git a/src/L1/gateways/L1StandardERC20Gateway.sol b/src/L1/gateways/L1StandardERC20Gateway.sol
@@ -81,19 +81,19 @@ contract L1StandardERC20Gateway is L1ERC20Gateway {
     /// @param _counterpart The address of L2StandardERC20Gateway in L2.
     /// @param _router The address of L1GatewayRouter.
     /// @param _messenger The address of L1ScrollMessenger.
-    /// @param _l2TokenImplementation The address of ScrollStandardERC20 implementation in L2.
-    /// @param _l2TokenFactory The address of ScrollStandardERC20Factory contract in L2.
     function initialize(
         address _counterpart,
         address _router,
         address _messenger,
-        address _l2TokenImplementation,
-        address _l2TokenFactory
+        address, /*_l2TokenImplementation*/
+        address /*_l2TokenFactory*/
     ) external initializer {
         ScrollGatewayBase._initialize(_counterpart, _router, _messenger);
 
+        /* comments out since not used any more
         __l2TokenImplementation = _l2TokenImplementation;
         __l2TokenFactory = _l2TokenFactory;
+        */
     }
 
     /*************************

diff --git a/src/L2/gateways/L2StandardERC20Gateway.sol b/src/L2/gateways/L2StandardERC20Gateway.sol
@@ -68,16 +68,17 @@ contract L2StandardERC20Gateway is L2ERC20Gateway {
     /// @param _counterpart The address of L1ETHGateway in L1.
     /// @param _router The address of L2GatewayRouter.
     /// @param _messenger The address of L2ScrollMessenger.
-    /// @param _tokenFactory The address of ScrollStandardERC20Factory.
     function initialize(
         address _counterpart,
         address _router,
         address _messenger,
-        address _tokenFactory
+        address /*_tokenFactory*/
     ) external initializer {
         ScrollGatewayBase._initialize(_counterpart, _router, _messenger);
 
+        /* comment out since no longer used
         __tokenFactory = _tokenFactory;
+        */
     }
 
     /*************************