Skip to content

Commit

Permalink
docs:clean repetitive words (#1309)
Browse files Browse the repository at this point in the history
  • Loading branch information
AdventureSeeker987 authored Apr 28, 2024
1 parent a70e4b2 commit 9e0fd5d
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion src/L2/gateways/L2CustomERC20Gateway.sol
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import {IScrollERC20Upgradeable} from "../../libraries/token/IScrollERC20Upgrade
/// @title L2ERC20Gateway
/// @notice The `L2ERC20Gateway` is used to withdraw custom ERC20 compatible tokens on layer 2 and
/// finalize deposit the tokens from layer 1.
/// @dev The withdrawn tokens tokens will be burned directly. On finalizing deposit, the corresponding
/// @dev The withdrawn tokens will be burned directly. On finalizing deposit, the corresponding
/// tokens will be minted and transferred to the recipient.
contract L2CustomERC20Gateway is L2ERC20Gateway {
/**********
Expand Down
2 changes: 1 addition & 1 deletion src/libraries/codec/BatchHeaderV0Codec.sol
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ library BatchHeaderV0Codec {

/// @notice Get the number of L1 messages popped before this batch.
/// @param batchPtr The start memory offset of the batch header in memory.
/// @return _totalL1MessagePopped The the number of L1 messages popped before this batch.
/// @return _totalL1MessagePopped The number of L1 messages popped before this batch.
function getTotalL1MessagePopped(uint256 batchPtr) internal pure returns (uint256 _totalL1MessagePopped) {
assembly {
_totalL1MessagePopped := shr(192, mload(add(batchPtr, 17)))
Expand Down
2 changes: 1 addition & 1 deletion src/libraries/codec/BatchHeaderV1Codec.sol
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ library BatchHeaderV1Codec {

/// @notice Get the number of L1 messages popped before this batch.
/// @param batchPtr The start memory offset of the batch header in memory.
/// @return _totalL1MessagePopped The the number of L1 messages popped before this batch.
/// @return _totalL1MessagePopped The number of L1 messages popped before this batch.
function getTotalL1MessagePopped(uint256 batchPtr) internal pure returns (uint256 _totalL1MessagePopped) {
assembly {
_totalL1MessagePopped := shr(192, mload(add(batchPtr, 17)))
Expand Down
2 changes: 1 addition & 1 deletion src/lido/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ According to the Scroll documentation, `L1ScrollMessenger`:
This contract is central in the L2-to-L1 communication process since all messages from L2 that verified by the zkevm proof are executed on behalf of this contract.

In case of a vulnerability in the `L1ScrollMessenger`, which allows the attacker to send arbitrary messages bypassing the the zkevm proof, an attacker can immediately drain tokens from the L1 bridge.
In case of a vulnerability in the `L1ScrollMessenger`, which allows the attacker to send arbitrary messages bypassing the zkevm proof, an attacker can immediately drain tokens from the L1 bridge.

Additional risk creates the upgradeability of the `L1ScrollMessenger`. Exist a risk of an attack with the replacement of the implementation with some malicious functionality. Such an attack might be reduced to the above vulnerability and steal all locked tokens on the L1 bridge.

Expand Down

0 comments on commit 9e0fd5d

Please sign in to comment.