Skip to content

Commit

Permalink
MAINT: Prefer signature over formatargspec
Browse files Browse the repository at this point in the history
Prefer modern method to get signature over deprecated method
  • Loading branch information
bashtage committed Sep 27, 2018
1 parent e1d1156 commit e4a5767
Showing 1 changed file with 9 additions and 4 deletions.
13 changes: 9 additions & 4 deletions statsmodels/base/wrapper.py
Original file line number Diff line number Diff line change
Expand Up @@ -96,10 +96,15 @@ def wrapper(self, *args, **kwargs):
obj = data.wrap_output(func(results, *args, **kwargs), how)
return obj

argspec = getargspec(func)
formatted = inspect.formatargspec(argspec[0], varargs=argspec[1],
defaults=argspec[3])

try: # Python 3.3+
sig = inspect.signature(func)
formatted = str(sig)
except AttributeError:
# TODO: Remove when Python 2.7 is dropped
argspec = getargspec(func)
formatted = inspect.formatargspec(argspec[0],
varargs=argspec[1],
defaults=argspec[3])
func_name = get_function_name(func)

wrapper.__doc__ = "%s%s\n%s" % (func_name, formatted, wrapper.__doc__)
Expand Down

0 comments on commit e4a5767

Please sign in to comment.