Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Properly fix license issue in CircleCI (facebook#362)
Summary: Apparently this seems to be the only way to make build work, with the updated licenses. It also follows the same strategy as Travis. I am using double pipe in `sdkmanager` command execution, to avoid breaking the build, because `sdkmanager` returns exit code 141 in case it meets the requirements requested. (e.g.: `yes | sdkmanager --licenses` returns 141, which in turn breaks the build due to `set -eo pipefail` Bash flags, that CircleCI is using in order to execute any scripts) For the record, I tried the following solutions, that did not work: * Add accepted license SHA in Android SDK licenses folder. * Accept all licenses prior to running the other jobs (with a separate job, working as a dependency to the rest of the Workflow jobs) (`yes | sdkmanager --licenses`) * Accept all licenses prior to executing any Gradle command (without a separate job) (`yes | sdkmanager --licenses`) Pull Request resolved: facebook#362 Differential Revision: D13817430 Pulled By: passy fbshipit-source-id: d8c95fc5b9202306dd50ea103b6e90142e73ef61
- Loading branch information