feat: support overflow of mark

VisActor · Dec 5, 2024 · 8530a70 · 8530a70
1 parent e1b2f41
commit 8530a70
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 2 deletions.
diff --git a/packages/vgrammar-core/src/types/mark.ts b/packages/vgrammar-core/src/types/mark.ts
@@ -261,6 +261,7 @@ export interface IMarkConfig {
    * set graphic name
    */
   graphicName?: string | ((element: IElement) => string);
+  overflow?: 'scroll' | 'hidden' | 'scroll-x' | 'scroll-y';
 }
 
 /**

diff --git a/packages/vgrammar-core/src/view/mark.ts b/packages/vgrammar-core/src/view/mark.ts
@@ -497,7 +497,8 @@ export class Mark extends GrammarBase implements IMark {
       'skipTheme',
       'enableSegments',
       'stateSort',
-      'graphicName'
+      'graphicName',
+      'overflow'
     ];
     if (config === null) {
       keys.forEach(key => {
@@ -637,7 +638,8 @@ export class Mark extends GrammarBase implements IMark {
       if (!this.graphicItem) {
         const graphicItem = createGraphicItem(this, GrammarMarkType.group, {
           pickable: false,
-          zIndex: this.spec.zIndex ?? 0
+          zIndex: this.spec.zIndex ?? 0,
+          overflow: this.spec.overflow
         }) as IGroup;
         if (this.spec.support3d || (Mark3DType as string[]).includes(this.markType)) {
           graphicItem.setMode('3d');
@@ -651,6 +653,10 @@ export class Mark extends GrammarBase implements IMark {
       }
     } else {
       this.graphicParent = groupGraphicItem;
+
+      this.graphicParent.setAttributes({
+        overflow: this.spec.overflow
+      });
     }
     this.graphicIndex = markIndex;
   }
@@ -684,6 +690,10 @@ export class Mark extends GrammarBase implements IMark {
         }
       }
 
+      if (!isNil(spec.overflow)) {
+        this.graphicItem.setAttribute('overflow', spec.overflow);
+      }
+
       // only update interactive
       this.elementMap.forEach(element => {
         element.updateGraphicItem();
-Original file line number
+Diff line change
@@ Expand Up / @@ -261,6 +261,7 @@ export interface IMarkConfig { @@
        * set graphic name
        */
       graphicName?: string | ((element: IElement) => string);
+      overflow?: 'scroll' | 'hidden' | 'scroll-x' | 'scroll-y';
     }
     /**
@@ Expand Down @@