Spec'ing creative scanning via BYOS/V1 trusted scoring signals #1398

morlovich · 2025-02-10T16:26:05Z

This also fixes trusted scoring signals params escaping in general to not escape commas
when not expected.

See #792 (comment)
and latter comments on that issue for more context.

Preview | Diff

orrb1

Thanks, Maks!

spec.bs

orrb1

Thanks, Maks!

spec.bs

morlovich · 2025-02-18T15:16:23Z

I suspect the failure is due to speced/bikeshed-boilerplate@123d968

qingxinwu · 2025-02-19T05:27:27Z

spec.bs

+1. Let |sendCreativeScanningMetadata| be |auctionConfig|'s [=auction config/send creative scanning
+  metadata=].
+1. If |auctionConfig|'s [=auction config/trusted scoring signals coordinator=] is not null,
+  set |sendCreativeScanningMetadata| to false.


mind pointing me to the code?

https://source.chromium.org/chromium/chromium/src/+/main:content/services/auction_worklet/seller_worklet.cc;drc=52fd6ac1d41dd9238853b800e48970eb164b2195;l=2178

The "fill in creative info" logic using that is also in the constructor that calls immediately below.

so is "hasPublicKey()" the same as coordinator not being null here? When coordinator is not null, the key fetch can also fail (spec) which causes no public key, right?

So in the spec at the moment, if the key fetch fails, it just fails the V2 fetch path.
The impl currently falls back (which that code incorporates since the key fetch happens before we get to it), but I think that fallback may no longer happen when the cache is on, which would then match the spec, both my addition and the actual fetch stuff?

I see, yeah I heard about the cache stuff would change things, but I'm not familiar with it.

spec.bs

qingxinwu · 2025-02-19T05:38:01Z

spec.bs

@@ -8357,6 +8403,9 @@ An <dfn>interest group ad</dfn> is a [=struct=] with the following [=struct/item
  : <dfn>ad render ID</dfn>
  :: A [=string=] containing up to 12 [=ASCII bytes=] uniquely identifying this ad. Sent instead
    of the full [=interest group ad=] for auctions executed on a server.
+  : <dfn>creative scanning metadata</dfn>
+  :: Null or a [=string=], initially null. Sent with V1 trusted scoring signals requests if


I don't think the spec has a definition of our concept of "V1". Can we have a (one or multiple sentences) definition of it in the spec, or replae V1 with something more explicit?

Maybe non-TEE?

It's good as long as that's clear to readers. Otherwise, a definition with short explaination can be helpful.

spec.bs

qingxinwu · 2025-02-21T17:19:39Z

spec.bs

 1. If |experimentGroupId| is not null:
  1. [=list/Append=] "`&experimentGroupId=`" to |queryParamsList|.
  1. [=list/Append=] [=serialize an integer|serialized=] |experimentGroupId| to |queryParamsList|.
+1. If |sendCreativeScanningMetadata| is true:
+  1. [=Add trusted signals param if needed=] given "`&adCreativeScanningMetadata=`",
+    the result of [=extracting creative scanning metadata=] given |ads|, |queryParamsList|.


nit: it's kinda confusing about which param is for which algorithm, but I don't see a better way to reword it.

morlovich

Applied the suggestions..

morlovich · 2025-02-21T18:08:26Z

spec.bs

@@ -8357,6 +8403,9 @@ An <dfn>interest group ad</dfn> is a [=struct=] with the following [=struct/item
  : <dfn>ad render ID</dfn>
  :: A [=string=] containing up to 12 [=ASCII bytes=] uniquely identifying this ad. Sent instead
    of the full [=interest group ad=] for auctions executed on a server.
+  : <dfn>creative scanning metadata</dfn>
+  :: Null or a [=string=], initially null. Sent with V1 trusted scoring signals requests if


spec.bs

qingxinwu

last few comments.

qingxinwu · 2025-02-21T20:44:38Z

spec.bs

 A <dfn>trusted scoring signals request</dfn> is a [=struct=] with the following [=struct/items=],
 representing all information needed to produce a trusted scoring signals fetch for a single scoring
 invocation:

 <dl dfn-for="trusted scoring signals request">
+  : <dfn>send creative scanning metadata</dfn>
+  :: A [=boolean=], to determine whether creative scanning metadata should be added to V1 requests.


one more v1.

qingxinwu · 2025-02-21T20:46:02Z

spec.bs

+[=creative info=] |componentAds|, an {{unsigned short}} |experimentGroupId|, and an [=origin=]
+|topLevelOrigin|:
+
+Note: When trusted scoring signals fetches are not batched, |ads|'s [=list/size=] is 1.


Suggested change

Note: When trusted scoring signals fetches are not batched, |ads|'s [=list/size=] is 1.

Note: When trusted scoring signals fetches are not batched, |ads|'s [=set/size=] is 1.

qingxinwu · 2025-02-21T20:46:56Z

spec.bs


 1. Let |queryParamsList| be a new empty [=list=].
+


nit: extra white line, due to my previous code suggestion.

Suggested change

qingxinwu · 2025-02-21T20:48:42Z

spec.bs

+  |queryParamsList|.
+1. Let |adComponentRenderURLs| be the result of [=extracting URLs from creative info=] given
+  |componentAds|.
+1. If |adComponentRenderURLs| is not [=list/is empty|empty=]:


qingxinwu · 2025-02-21T21:13:14Z

spec.bs

+To <dfn>extract component ad creative scanning metadata</dfn> given a [=list=] of
+[=interest group ad=] |bidAdComponents|:
+
+  1. Let |result| be a new <code>[=sequence=]<{{USVString}}></code>.


each element can be null, right?

Suggested change

1. Let |result| be a new <code>[=sequence=]<{{USVString}}></code>.

1. Let |result| be a new <code>[=sequence=]<{{USVString?}}></code>.

qingxinwu · 2025-02-21T21:18:14Z

spec.bs

+1. Let |mainAd| be the result of [=filling in creative info=] given |sendCreativeScanningMetadata|,
+  |generatedBid|'s [=generated bid/ad descriptor=], |owner|, [=generated bid/bid ad=].
+1. Let |adComponents| be a new empty [=set=].
+1. For |i| between 0 and |generatedBid|'s [=generated bid/bid ad components=]'s [=list/size=] - 1,


Adding fields.

dd5653d

JensenPaul added the spec Relates to the spec label Feb 11, 2025

Maks Orlovich added 7 commits February 11, 2025 13:09

Pass to scoreAd()

78aec29

Add new type.

748d336

Caller side. Now only sender side remains.

13210f9

Fix the merging map.

ddce018

Fix up [=build batched trusted scoring signals url=]

7724161

Fix up the types. Only missing the new fields right now, I think.

f190c99

The rest of query params, fix escaping.

5535d84

morlovich changed the title ~~WIP: working on spec'ing creative scanning~~ Spec'ing creative scanning via BYOS/V1 trusted scoring signals Feb 13, 2025

morlovich requested a review from orrb1 February 13, 2025 16:07

orrb1 reviewed Feb 13, 2025

View reviewed changes

spec.bs Outdated Show resolved Hide resolved

spec.bs Show resolved Hide resolved

spec.bs Outdated Show resolved Hide resolved

spec.bs Outdated Show resolved Hide resolved

Apply feedback.

e557a4e

orrb1 approved these changes Feb 14, 2025

View reviewed changes

spec.bs Outdated Show resolved Hide resolved

spec.bs Show resolved Hide resolved

spec.bs Outdated Show resolved Hide resolved

Apply Orr's wording suggestion.

21c391a

morlovich requested a review from qingxinwu February 18, 2025 14:17

Merge branch 'main' into spec-creative-scan

0b5b6b5

qingxinwu reviewed Feb 19, 2025

View reviewed changes

Apply the immediately actionable of Qingxin's feedback

ce87e66

qingxinwu reviewed Feb 21, 2025

View reviewed changes

Apply more feedback

2cee4dc

morlovich commented Feb 21, 2025

View reviewed changes

qingxinwu reviewed Feb 21, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Spec'ing creative scanning via BYOS/V1 trusted scoring signals #1398

Spec'ing creative scanning via BYOS/V1 trusted scoring signals #1398

morlovich commented Feb 10, 2025 •

edited by pr-preview bot

Loading

orrb1 left a comment

orrb1 left a comment

morlovich commented Feb 18, 2025

qingxinwu Feb 19, 2025

morlovich Feb 19, 2025

qingxinwu Feb 19, 2025

morlovich Feb 19, 2025

qingxinwu Feb 19, 2025

qingxinwu Feb 19, 2025

morlovich Feb 19, 2025

qingxinwu Feb 19, 2025

morlovich Feb 21, 2025

qingxinwu Feb 21, 2025

morlovich left a comment

morlovich Feb 21, 2025

qingxinwu left a comment

qingxinwu Feb 21, 2025

qingxinwu Feb 21, 2025

qingxinwu Feb 21, 2025 •

edited

Loading

qingxinwu Feb 21, 2025

qingxinwu Feb 21, 2025

qingxinwu Feb 21, 2025

	Note: When trusted scoring signals fetches are not batched, \|ads\|'s [=list/size=] is 1.
	Note: When trusted scoring signals fetches are not batched, \|ads\|'s [=set/size=] is 1.

	1. If \|adComponentRenderURLs\| is not [=list/is empty\|empty=]:
	1. If \|adComponentRenderURLs\| [=list/is not empty=]:

	1. Let \|result\| be a new <code>[=sequence=]<{{USVString}}></code>.
	1. Let \|result\| be a new <code>[=sequence=]<{{USVString?}}></code>.

	1. For \|i\| between 0 and \|generatedBid\|'s [=generated bid/bid ad components=]'s [=list/size=] - 1,
	1. [=list/for each=] \|i\| in [=the range=] from 0 to \|generatedBid\|'s [=generated bid/bid ad components=]'s [=list/size=] - 1,

Spec'ing creative scanning via BYOS/V1 trusted scoring signals #1398

Are you sure you want to change the base?

Spec'ing creative scanning via BYOS/V1 trusted scoring signals #1398

Conversation

morlovich commented Feb 10, 2025 • edited by pr-preview bot Loading

orrb1 left a comment

Choose a reason for hiding this comment

orrb1 left a comment

Choose a reason for hiding this comment

morlovich commented Feb 18, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

morlovich left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

qingxinwu left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

qingxinwu Feb 21, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

morlovich commented Feb 10, 2025 •

edited by pr-preview bot

Loading

qingxinwu Feb 21, 2025 •

edited

Loading