Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pandas fix #191

Merged
merged 2 commits into from
Jan 24, 2024
Merged

Pandas fix #191

merged 2 commits into from
Jan 24, 2024

Conversation

gbarter
Copy link
Member

@gbarter gbarter commented Jan 24, 2024

Purpose

Pandas 2.2 changed the output sort rules for merge/join operations and this caused some rows indices to be mismatched. Added sort=True to all operations to clear that up. Also fixes some "Future Deprecation Warnings"

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

  • I have run existing tests which pass locally with my changes
  • I have added new tests or examples that prove my fix is effective or that my feature works
  • I have added necessary documentation

@gbarter gbarter merged commit a2761ac into develop Jan 24, 2024
24 checks passed
@gbarter gbarter deleted the pandas_fix branch January 24, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant