Skip to content

Commit

Permalink
UefiCpuPkg/RegisterCpuFeaturesLib: Remove useless functions.
Browse files Browse the repository at this point in the history
Remove useless APIs, simplify the code logic.

BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1375

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Eric Dong <[email protected]>
Reviewed-by: Ray Ni <[email protected]>
  • Loading branch information
ydong10 committed Apr 4, 2019

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
1 parent 37f9fea commit 79be3d2
Showing 2 changed files with 2 additions and 86 deletions.
36 changes: 1 addition & 35 deletions UefiCpuPkg/Include/Library/RegisterCpuFeaturesLib.h
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
/** @file
Register CPU Features Library to register and manage CPU features.
Copyright (c) 2017, Intel Corporation. All rights reserved.<BR>
Copyright (c) 2017 - 2019, Intel Corporation. All rights reserved.<BR>
This program and the accompanying materials
are licensed and made available under the terms and conditions of the BSD License
which accompanies this distribution. The full text of the license may be found at
@@ -166,40 +166,6 @@ IsCpuFeatureInSetting (
IN UINT32 Feature
);

/**
Determines if a CPU feature is set in PcdCpuFeaturesCapability bit mask.
@param[in] Feature The bit number of the CPU feature to check in the PCD
PcdCpuFeaturesCapability.
@retval TRUE The CPU feature is set in PcdCpuFeaturesCapability.
@retval FALSE The CPU feature is not set in PcdCpuFeaturesCapability.
@note This service could be called by BSP only.
**/
BOOLEAN
EFIAPI
IsCpuFeatureCapability (
IN UINT32 Feature
);

/**
Determines if a CPU feature is set in PcdCpuFeaturesUserConfiguration bit mask.
@param[in] Feature The bit number of the CPU feature to check in the PCD
PcdCpuFeaturesUserConfiguration.
@retval TRUE The CPU feature is set in PcdCpuFeaturesUserConfiguration.
@retval FALSE The CPU feature is not set in PcdCpuFeaturesUserConfiguration.
@note This service could be called by BSP only.
**/
BOOLEAN
EFIAPI
IsCpuFeatureUserConfiguration (
IN UINT32 Feature
);

/**
Prepares for the data used by CPU feature detection and initialization.
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
/** @file
CPU Register Table Library functions.
Copyright (c) 2017, Intel Corporation. All rights reserved.<BR>
Copyright (c) 2017 - 2019, Intel Corporation. All rights reserved.<BR>
This program and the accompanying materials
are licensed and made available under the terms and conditions of the BSD License
which accompanies this distribution. The full text of the license may be found at
@@ -1242,56 +1242,6 @@ IsCpuFeatureInSetting (
);
}

/**
Determines if a CPU feature is set in PcdCpuFeaturesCapability bit mask.
@param[in] Feature The bit number of the CPU feature to check in the PCD
PcdCpuFeaturesCapability
@retval TRUE The CPU feature is set in PcdCpuFeaturesCapability.
@retval FALSE The CPU feature is not set in PcdCpuFeaturesCapability.
@note This service could be called by BSP only.
**/
BOOLEAN
EFIAPI
IsCpuFeatureCapability (
IN UINT32 Feature
)
{
return IsCpuFeatureSetInCpuPcd (
(UINT8 *)PcdGetPtr (PcdCpuFeaturesCapability),
PcdGetSize (PcdCpuFeaturesCapability),
Feature
);

}

/**
Determines if a CPU feature is set in PcdCpuFeaturesUserConfiguration bit mask.
@param[in] Feature The bit number of the CPU feature to check in the PCD
PcdCpuFeaturesUserConfiguration
@retval TRUE The CPU feature is set in PcdCpuFeaturesUserConfiguration.
@retval FALSE The CPU feature is not set in PcdCpuFeaturesUserConfiguration.
@note This service could be called by BSP only.
**/
BOOLEAN
EFIAPI
IsCpuFeatureUserConfiguration (
IN UINT32 Feature
)
{
return IsCpuFeatureSetInCpuPcd (
(UINT8 *)PcdGetPtr (PcdCpuFeaturesUserConfiguration),
PcdGetSize (PcdCpuFeaturesUserConfiguration),
Feature
);

}

/**
Switches to assigned BSP after CPU features initialization.

0 comments on commit 79be3d2

Please sign in to comment.