Skip to content

Commit

Permalink
MdePkg/BaseLib: Remove definitions of two functions
Browse files Browse the repository at this point in the history
InternalCharToUpper and InternalBaseLibAsciiToUpper are internal functions
and now we will introduce public functions that have the same effects.
So I remove their definitions in BaseLibInternals.h.
https://bugzilla.tianocore.org/show_bug.cgi?id=1369

Cc: Michael D Kinney <[email protected]>
Cc: Liming Gao <[email protected]>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Shenglei Zhang <[email protected]>
Reviewed-by: Liming Gao <[email protected]>
Reviewed-by: Ray Ni <[email protected]>
  • Loading branch information
shenglei10 authored and lgao4 committed Jan 31, 2019
1 parent 5dbfa01 commit 8c9b495
Showing 1 changed file with 1 addition and 43 deletions.
44 changes: 1 addition & 43 deletions MdePkg/Library/BaseLib/BaseLibInternals.h
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
/** @file
Declaration of internal functions in BaseLib.
Copyright (c) 2006 - 2018, Intel Corporation. All rights reserved.<BR>
Copyright (c) 2006 - 2019, Intel Corporation. All rights reserved.<BR>
This program and the accompanying materials
are licensed and made available under the terms and conditions of the BSD License
which accompanies this distribution. The full text of the license may be found at
Expand Down Expand Up @@ -469,28 +469,6 @@ InternalIsDecimalDigitCharacter (
);


/**
Convert a Unicode character to upper case only if
it maps to a valid small-case ASCII character.
This internal function only deal with Unicode character
which maps to a valid small-case ASCII character, i.e.
L'a' to L'z'. For other Unicode character, the input character
is returned directly.
@param Char The character to convert.
@retval LowerCharacter If the Char is with range L'a' to L'z'.
@retval Unchanged Otherwise.
**/
CHAR16
EFIAPI
InternalCharToUpper (
IN CHAR16 Char
);


/**
Convert a Unicode character to numerical value.
Expand Down Expand Up @@ -552,26 +530,6 @@ InternalAsciiIsDecimalDigitCharacter (
);


/**
Converts a lowercase Ascii character to upper one.
If Chr is lowercase Ascii character, then converts it to upper one.
If Value >= 0xA0, then ASSERT().
If (Value & 0x0F) >= 0x0A, then ASSERT().
@param Chr one Ascii character
@return The uppercase value of Ascii character
**/
CHAR8
EFIAPI
InternalBaseLibAsciiToUpper (
IN CHAR8 Chr
);


/**
Check if a ASCII character is a hexadecimal character.
Expand Down

0 comments on commit 8c9b495

Please sign in to comment.