do not silently ingnore rows

WanzyShu · Mar 16, 2016 · 948b19a · 948b19a
1 parent ec949d7
commit 948b19a
Showing 1 changed file with 10 additions and 0 deletions.
diff --git a/server/src/main/java/io/druid/segment/realtime/firehose/PredicateFirehose.java b/server/src/main/java/io/druid/segment/realtime/firehose/PredicateFirehose.java
@@ -20,6 +20,7 @@
 package io.druid.segment.realtime.firehose;
 
 import com.google.common.base.Predicate;
+import com.metamx.common.logger.Logger;
 import io.druid.data.input.Firehose;
 import io.druid.data.input.InputRow;
 
@@ -31,6 +32,10 @@
  */
 public class PredicateFirehose implements Firehose
 {
+  private static final Logger log = new Logger(PredicateFirehose.class);
+  private static final int IGNORE_THRESHOLD = 5000;
+  private long ignored = 0;
+
   private final Firehose firehose;
   private final Predicate<InputRow> predicate;
 
@@ -55,6 +60,11 @@ public boolean hasMore()
         savedInputRow = row;
         return true;
       }
+      // Do not silently discard the rows
+      if (ignored % IGNORE_THRESHOLD == 0) {
+        log.warn("[%,d] InputRow(s) ignored as they do not satisfy the predicate", ignored);
+      }
+      ignored++;
     }
 
     return false;