Skip to content

Commit

Permalink
Fix ICSPullToRefresh pod to swift 3 compat. Update README.md.
Browse files Browse the repository at this point in the history
ICSPullToRefresh shouts out error when build for simulator. Thus updated
it to use swift 3.

Updated also to README.md to remove steps that are not needed, and added
more info for notice for code.
  • Loading branch information
haxpor committed Jan 22, 2017
1 parent 2ce5641 commit 7966bed
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 20 deletions.
2 changes: 1 addition & 1 deletion Podfile
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ target "Potatso" do
pod 'CallbackURLKit', :path => "./Library/CallbackURLKit"
pod 'ICDMaterialActivityIndicatorView', '~> 0.1.0'
pod 'Reveal-iOS-SDK', '~> 1.6.2', :configurations => ['Debug']
pod 'ICSPullToRefresh', '~> 0.4'
pod 'ICSPullToRefresh', '~> 0.6'
pod 'ISO8601DateFormatter', '~> 0.8'
pod 'Alamofire'
pod 'ObjectMapper'
Expand Down
8 changes: 4 additions & 4 deletions Podfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ PODS:
- Helpshift (5.6.1)
- ICDMaterialActivityIndicatorView (0.1.2)
- ICSMainFramework (0.0.1)
- ICSPullToRefresh (0.4)
- ICSPullToRefresh (0.6)
- ISO8601DateFormatter (0.8)
- KeychainAccess (3.0.1)
- KissXML (5.1.2):
Expand Down Expand Up @@ -86,7 +86,7 @@ DEPENDENCIES:
- Helpshift (= 5.6.1)
- ICDMaterialActivityIndicatorView (~> 0.1.0)
- ICSMainFramework (from `./Library/ICSMainFramework/`)
- ICSPullToRefresh (~> 0.4)
- ICSPullToRefresh (~> 0.6)
- ISO8601DateFormatter (~> 0.8)
- KeychainAccess
- KissXML
Expand Down Expand Up @@ -125,7 +125,7 @@ SPEC CHECKSUMS:
Helpshift: b48366299844f119acf5e91d02a2e89288494fe6
ICDMaterialActivityIndicatorView: 3f02a9dc9e52417023a98385d631c93d3f95c465
ICSMainFramework: 56240e9556d3b0755fc9c934a91ee8ebd09cb753
ICSPullToRefresh: 9e6720df41f6d3e8a31e3cdd99a0b922850abe85
ICSPullToRefresh: a64f102c6558cc34270ea60e99df7c91d1f3d2c0
ISO8601DateFormatter: 4551b6ce4f83185425f583b0b3feb3c7b59b942c
KeychainAccess: 017ea25e313a49eda10bb19b0bb0760fb1edfe1a
KissXML: 246c842586bb77110e04fb88e19376d96245c856
Expand All @@ -139,6 +139,6 @@ SPEC CHECKSUMS:
Reveal-iOS-SDK: e2250b3c155bcfac53ae223ddc1f76d08f206c33
SwiftColor: c240d8cb2e1a29d731ae8deca8739eac6b9c56bd

PODFILE CHECKSUM: 3618cf0284e05c36aa68c662ec5d10d5b9728046
PODFILE CHECKSUM: f69f815281cc3a30617e9ae9ec9f4473bf0d0e7d

COCOAPODS: 1.1.1
19 changes: 4 additions & 15 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -33,21 +33,9 @@ Be warned that you **should not** call `pod update` as newer version of pod fram
1. `git submodule update --init` to update git submodule
2. `pod install` to pull down dependencies into our project
3. `carthage update` to pull down dependencies into `Carthage/Checkouts` folder and build each one
4. If **not** yet have "YAML.framework" as part of "Linked Frameworks and Libraries" section in "General" tab of Potatso target, then drag and drop `YAML.framework` file from `Carthage/Build/iOS` into it.
5. If **not** yet have "Carthage" run script inside "Build Phases" of Potato target, then click the "+" icon and choose "New Run Script Phase". Create a Run Script with name "Carthage" in which has `bin/sh` as shell with following content

```json
/usr/local/bin/carthage copy-frameworks
```
and add the paths to added framework under "Input Files" as follows

```json
$(SRCROOT)/Carthage/Build/iOS/YAML.framework
```

6. Search for `io.wasin.potatso` for project-wide, and replace it with your own domain name. This is necessary as you need to create your own provisioning profile as it uses your domain name.
7. Build the project. Done.
4. Search for `io.wasin.potatso` for project-wide, and replace it with your own domain name. This is necessary as you need to create your own provisioning profile as it uses your domain name.
5. Follow the guide in *Set up Guide - Apple Developer Website* section.
6. Build and Run the project. Done.

## Set up Guide - Apple Developer Website

Expand Down Expand Up @@ -83,6 +71,7 @@ There're a couple of issues that needed to look at, but at tested, it doens't ef
JSONToMap = result.value as AnyObject?
}
```
* Potatso core code depends on version `1.7.0` of Eureka with manual migration to Swift 3. It's already done and linked to project. But you will see `observeValue()` function in `Eureka/Source/Rows/PostalAddressRow.swift` that has been commented for all of its function code due to Eureka's newer version `2.0.0-beta.1` doesn't include such file in the project anymore, but it still works with no problem. This note is meant to mark that there is going to be a lot of effort if we decide to depend on Eureka version `2.0.0-beta.1` as we need to change a lot of Potatso core code.

## How To Contribute

Expand Down

0 comments on commit 7966bed

Please sign in to comment.