Removing unused class SearchDataManager and unused dependency on Shar…

…edPreferences in Search
WiiliamChik · Apr 16, 2019 · 6f3d6a0 · 6f3d6a0
1 parent 113e12a
commit 6f3d6a0
Show file tree

Hide file tree

Showing 4 changed files with 1 addition and 169 deletions.
diff --git a/search/src/main/java/io/plaidapp/search/dagger/Injector.kt b/search/src/main/java/io/plaidapp/search/dagger/Injector.kt
@@ -16,8 +16,6 @@
 
 package io.plaidapp.search.dagger
 
-import io.plaidapp.core.dagger.SharedPreferencesModule
-import io.plaidapp.core.designernews.data.login.LoginLocalDataSource
 import io.plaidapp.search.ui.SearchActivity
 import io.plaidapp.ui.coreComponent
 
@@ -32,12 +30,6 @@ object Injector {
     fun inject(activity: SearchActivity) {
         DaggerSearchComponent.builder()
             .coreComponent(activity.coreComponent())
-            .sharedPreferencesModule(
-                SharedPreferencesModule(
-                    activity,
-                    LoginLocalDataSource.DESIGNER_NEWS_PREF
-                )
-            )
             .searchActivity(activity)
             .build()
             .inject(activity)

diff --git a/search/src/main/java/io/plaidapp/search/dagger/SearchComponent.kt b/search/src/main/java/io/plaidapp/search/dagger/SearchComponent.kt
@@ -20,7 +20,6 @@ import dagger.BindsInstance
 import dagger.Component
 import io.plaidapp.core.dagger.BaseActivityComponent
 import io.plaidapp.core.dagger.CoreComponent
-import io.plaidapp.core.dagger.SharedPreferencesModule
 import io.plaidapp.core.dagger.scope.FeatureScope
 import io.plaidapp.search.ui.SearchActivity
 
@@ -37,6 +36,5 @@ interface SearchComponent : BaseActivityComponent<SearchActivity> {
         fun build(): SearchComponent
         @BindsInstance fun searchActivity(activity: SearchActivity): Builder
         fun coreComponent(component: CoreComponent): Builder
-        fun sharedPreferencesModule(module: SharedPreferencesModule): Builder
     }
 }
diff --git a/search/src/main/java/io/plaidapp/search/dagger/SearchModule.kt b/search/src/main/java/io/plaidapp/search/dagger/SearchModule.kt
@@ -24,22 +24,18 @@ import dagger.Binds
 import dagger.Module
 import dagger.Provides
 import io.plaidapp.R
-import io.plaidapp.core.dagger.SharedPreferencesModule
 import io.plaidapp.core.dagger.designernews.DesignerNewsDataModule
 import io.plaidapp.core.dagger.dribbble.DribbbleDataModule
 import io.plaidapp.core.dagger.qualifier.IsPocketInstalled
-import io.plaidapp.core.data.DataLoadingSubject
 import io.plaidapp.core.data.pocket.PocketUtils
-import io.plaidapp.search.domain.SearchDataManager
 import io.plaidapp.search.ui.SearchActivity
 import io.plaidapp.search.ui.SearchViewModel
 import io.plaidapp.search.ui.SearchViewModelFactory
 
 @Module(
     includes = [
         DribbbleDataModule::class,
-        DesignerNewsDataModule::class,
-        SharedPreferencesModule::class
+        DesignerNewsDataModule::class
     ]
 )
 abstract class SearchModule {
@@ -53,9 +49,6 @@ abstract class SearchModule {
     @Binds
     abstract fun context(activity: Activity): Context
 
-    @Binds
-    abstract fun dataLoadingSubject(searchDataManager: SearchDataManager): DataLoadingSubject
-
     @Module
     companion object {
 

diff --git a/search/src/main/java/io/plaidapp/search/domain/SearchDataManager.kt b/search/src/main/java/io/plaidapp/search/domain/SearchDataManager.kt