optimize txs tracing

WlinkNET · Jan 25, 2021 · 076b660 · 076b660
1 parent 8bb379d
commit 076b660
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 8 deletions.
diff --git a/gossip/emitter/emitter.go b/gossip/emitter/emitter.go
@@ -194,10 +194,12 @@ func (em *Emitter) EmitEvent() *inter.EventPayload {
 		return nil
 	}
 
-	for _, tt := range poolTxs {
-		for _, t := range tt {
-			span := tracing.CheckTx(t.Hash(), "Emitter.EmitEvent(candidate)")
-			defer span.Finish()
+	if tracing.Enabled() {
+		for _, tt := range poolTxs {
+			for _, t := range tt {
+				span := tracing.CheckTx(t.Hash(), "Emitter.EmitEvent(candidate)")
+				defer span.Finish()
+			}
 		}
 	}
 
@@ -224,9 +226,11 @@ func (em *Emitter) EmitEvent() *inter.EventPayload {
 	em.Log.Info("New event emitted", "id", e.ID(), "parents", len(e.Parents()), "by", e.Creator(), "frame", e.Frame(), "txs", e.Txs().Len(), "t", time.Since(start))
 
 	// metrics
-	for _, t := range e.Txs() {
-		span := tracing.CheckTx(t.Hash(), "Emitter.EmitEvent()")
-		defer span.Finish()
+	if tracing.Enabled() {
+		for _, t := range e.Txs() {
+			span := tracing.CheckTx(t.Hash(), "Emitter.EmitEvent()")
+			defer span.Finish()
+		}
 	}
 
 	return e

diff --git a/integration/db.go b/integration/db.go
@@ -110,6 +110,6 @@ func (p *DummyFlushableProducer) NotFlushedSizeEst() int {
 	return 0
 }
 
-func (p *DummyFlushableProducer) Flush(id []byte) error {
+func (p *DummyFlushableProducer) Flush(_ []byte) error {
 	return nil
 }
diff --git a/tracing/tx-tracing.go b/tracing/tx-tracing.go
@@ -19,6 +19,10 @@ func SetEnabled(val bool) {
 	enabled = val
 }
 
+func Enabled() bool {
+	return enabled
+}
+
 func StartTx(tx common.Hash, operation string) {
 	if !enabled {
 		return