added some warning comments

Signed-off-by: Min Min <[email protected]>
WormOn · Dec 31, 2021 · 8cdbe85 · 8cdbe85
1 parent b87b590
commit 8cdbe85
Showing 1 changed file with 8 additions and 6 deletions.
diff --git a/pkg/microservice/aslan/core/common/repository/models/registry_namespace.go b/pkg/microservice/aslan/core/common/repository/models/registry_namespace.go
@@ -30,12 +30,14 @@ type RegistryNamespace struct {
 	RegType     string             `bson:"reg_type"                    json:"reg_type"`
 	RegProvider string             `bson:"reg_provider"                json:"reg_provider"`
 	IsDefault   bool               `bson:"is_default"                  json:"is_default"`
-	Namespace   string             `bson:"namespace,omitempty"         json:"namespace,omitempty"`
-	AccessKey   string             `bson:"access_key"                  json:"access_key"`
-	SecretKey   string             `bson:"secret_key"                  json:"secret_key"`
-	Region      string             `bson:"region,omitempty"            json:"region,omitempty"`
-	UpdateTime  int64              `bson:"update_time"                 json:"update_time"`
-	UpdateBy    string             `bson:"update_by"                   json:"update_by"`
+	// Namespace is NOT a required field, this could be empty when the registry is AWS ECR or so.
+	// use with CAUTION !!!!
+	Namespace  string `bson:"namespace,omitempty"         json:"namespace,omitempty"`
+	AccessKey  string `bson:"access_key"                  json:"access_key"`
+	SecretKey  string `bson:"secret_key"                  json:"secret_key"`
+	Region     string `bson:"region,omitempty"            json:"region,omitempty"`
+	UpdateTime int64  `bson:"update_time"                 json:"update_time"`
+	UpdateBy   string `bson:"update_by"                   json:"update_by"`
 }
 
 func (ns *RegistryNamespace) Validate() error {