-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Solana/sdk set evm cost initialize #116
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
9db0b06
solana: fixes typo
scnale e065b98
solana: adds evm cost into the `initialize` sdk function
scnale bb7ce70
evm: sets the EVM tx size
scnale 9508eba
solana: improves `Tail` type in tests
scnale 98d7704
solana: fixes comparison in SDK
scnale 3d0e5a5
solana: fixes sdk tests
scnale dad1240
solana: fixes IDL
scnale a1fe84b
solana: fixes SDK test
scnale File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,7 @@ | ||
{ | ||
"owner": "C4g4fRKT1xF6tFvo8QoPccVGsrzFgbHZnMRXfsSNQ8dm", | ||
"feeRecipient": "hiUN9rS9VTPVGYc71Vf2d6iyFLvsQaSsqWhxydqdaZf", | ||
"admins": [] | ||
"admins": [], | ||
"evmRelayGas": "400000", | ||
"evmRelayTxSize": "1211" | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
import { Connection, PublicKey, Signer, VersionedTransactionResponse } from '@solana/web3.js'; | ||
import { Chain } from '@wormhole-foundation/sdk-base'; | ||
import { Chain, RoTuple } from '@wormhole-foundation/sdk-base'; | ||
import { UniversalAddress } from '@wormhole-foundation/sdk-definitions'; | ||
import { | ||
SolanaPriceOracle, | ||
|
@@ -13,6 +13,8 @@ import testProgramKeypair from '../../programs/token-bridge-relayer/test-program | |
|
||
const $ = new TestsHelper(); | ||
|
||
type Tail<T extends RoTuple> = T extends readonly [unknown, ...infer T2] ? T2 : never; | ||
|
||
export class TbrWrapper { | ||
readonly client: SolanaTokenBridgeRelayer; | ||
readonly signer: Signer; | ||
|
@@ -76,12 +78,10 @@ export class TbrWrapper { | |
} | ||
} | ||
|
||
async initialize(args: { | ||
owner: PublicKey; | ||
feeRecipient: PublicKey; | ||
admins: PublicKey[]; | ||
}): Promise<VersionedTransactionResponse | null> { | ||
return $.getTransaction($.sendAndConfirm(await this.client.initialize(args), this.signer)); | ||
async initialize( | ||
...args: Tail<Parameters<SolanaTokenBridgeRelayer["initialize"]>> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. very nice |
||
): Promise<VersionedTransactionResponse | null> { | ||
return $.getTransaction($.sendAndConfirm(await this.client.initialize(this.signer.publicKey, ...args), this.signer)); | ||
} | ||
|
||
async submitOwnerTransferRequest( | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both could be just numbers too. 🤔
The real datatype we'd want is a uint... and preferably one with units...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They're both
uint64
for some reason. I think that this is excessive for the tx size but I don't recall if this makes sense for the gas limit. I think we choseuint32
in SR, right?