add virtual destructor

XiaoMi · Jul 6, 2020 · 918a449 · 918a449
1 parent 4ae03d9
commit 918a449
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/include/galaxy_fds.h b/include/galaxy_fds.h
@@ -26,6 +26,8 @@ class MetadataBean;
 
 class GalaxyFDS {
 public:
+  virtual ~GalaxyFDS() = default;
+
   virtual std::vector<std::shared_ptr<FDSBucket> > listBuckets() = 0;
 
   virtual void createBucket(const std::string& bucketName) = 0;

diff --git a/include/galaxy_fds_client.h b/include/galaxy_fds_client.h
@@ -31,6 +31,8 @@ class GalaxyFDSClient : public GalaxyFDS {
   GalaxyFDSClient(const std::string& accessKey, const std::string& secretKey,
       const FDSClientConfiguration& config);
 
+  ~GalaxyFDSClient() override = default;
+
   static const std::string DATE_FORMAT;
 
   std::vector<std::shared_ptr<FDSBucket> > listBuckets() override;