kunit: Fix potential null dereference in kunit_device_driver_test()

kunit_kzalloc() may return a NULL pointer, dereferencing it without NULL check may lead to NULL dereference. Add a NULL check for test_state. Link: https://lore.kernel.org/r/[email protected] Fixes: d03c720 ("kunit: Add APIs for managing devices") Signed-off-by: Zichen Xie <[email protected]> Cc: [email protected] Reviewed-by: David Gow <[email protected]> Signed-off-by: Shuah Khan <[email protected]>
YAOYIA · Nov 19, 2024 · 435c20e · 435c20e
1 parent aadf9cb
commit 435c20e
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/lib/kunit/kunit-test.c b/lib/kunit/kunit-test.c
@@ -805,6 +805,8 @@ static void kunit_device_driver_test(struct kunit *test)
 	struct device *test_device;
 	struct driver_test_state *test_state = kunit_kzalloc(test, sizeof(*test_state), GFP_KERNEL);
 
+	KUNIT_ASSERT_NOT_ERR_OR_NULL(test, test_state);
+
 	test->priv = test_state;
 	test_driver = kunit_driver_create(test, "my_driver");