refactor: use ctx.setRawHeader (eggjs#61)

YingJiang · Aug 29, 2016 · 4f3029d · 4f3029d
1 parent 2adf02d
commit 4f3029d
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 7 deletions.
diff --git a/app/extend/context.js b/app/extend/context.js
@@ -234,7 +234,7 @@ const proto = module.exports = {
     if (!jsonpFunction) {
       this.body = obj;
     } else {
-      this.set('X-Content-Type-Options', 'nosniff');
+      this.setRawHeader('X-Content-Type-Options', 'nosniff');
       this.type = 'js';
       this.body = jsonpBody(obj, jsonpFunction, options);
     }

diff --git a/app/middleware/meta.js b/app/middleware/meta.js
@@ -8,11 +8,11 @@ module.exports = (_, app) => {
   const poweredBy = typeof app.poweredBy === 'string' ? app.poweredBy : null;
 
   return function* meta(next) {
-    if (poweredBy) this.set('X-Powered-By', poweredBy);
+    if (poweredBy) this.setRawHeader('X-Powered-By', poweredBy);
 
     yield next;
 
     // total response time header
-    this.set('X-Readtime', Date.now() - this.starttime);
+    this.setRawHeader('X-Readtime', Date.now() - this.starttime);
   };
 };
diff --git a/app/middleware/site_file.js b/app/middleware/site_file.js
@@ -1,9 +1,8 @@
 'use strict';
 
-// favicon.ico crossdomain.xml robots.txt support
-
 const path = require('path');
-const MAX_AGE = 30 * 24 * 68 * 60;
+
+const MAX_AGE_VALUE = 'public, max-age=2592000'; // 30 days
 
 module.exports = options => {
   return function* siteFile(next) {
@@ -20,7 +19,7 @@ module.exports = options => {
     // '/robots.txt': Buffer <xx..
     // content is buffer
     if (Buffer.isBuffer(content)) {
-      this.set('Cache-Control', `public, max-age=${MAX_AGE}`);
+      this.setRawHeader('Cache-Control', MAX_AGE_VALUE);
       this.body = content;
       this.type = path.extname(this.path);
       return;