Destroy input frame on GMP encode on error conditions.

YouZhang · Jul 1, 2014 · e4a2fad · e4a2fad
1 parent 76bd633
commit e4a2fad
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/module/gmp-openh264.cpp b/module/gmp-openh264.cpp
@@ -261,6 +261,7 @@ class OpenH264VideoEncoder : public GMPVideoEncoder {
  assert (!frameTypes.empty());
  if (frameTypes.empty()) {
  GMPLOG (GL_ERROR, "No frame types provided");
+ inputImage->Destroy();
  return GMPVideoGenericErr;
  }
 
@@ -366,6 +367,7 @@ class OpenH264VideoEncoder : public GMPVideoEncoder {
  GMPVideoErr err = host_->CreateFrame (kGMPEncodedVideoFrame, &ftmp);
  if (err != GMPVideoNoErr) {
  GMPLOG (GL_ERROR, "Error creating encoded frame");
+ frame->Destroy();
  return;
  }
 
@@ -389,6 +391,7 @@ class OpenH264VideoEncoder : public GMPVideoEncoder {
  if (err != GMPVideoNoErr) {
  GMPLOG (GL_ERROR, "Error allocating frame data");
  f->Destroy();
+ frame->Destroy();
  return;
  }