Skip to content

Commit

Permalink
fix: added missing err check to table_info_checker (apache#5557)
Browse files Browse the repository at this point in the history
  • Loading branch information
Keon Amini authored Jun 23, 2023
1 parent 4250e11 commit d3bc54b
Showing 1 changed file with 12 additions and 0 deletions.
12 changes: 12 additions & 0 deletions backend/core/utils/table_info_checker.go
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,16 @@ func (checker *TableInfoChecker) parseDirRecursively(modelsDir string, additiona
packagesMap := make(map[string]*ast.Package)
ignorablePackages := append(checker.ignoredPackages, additionalIgnorablePackages...)
err := filepath.WalkDir(modelsDir, func(path string, d fs2.DirEntry, err error) error {
if err != nil {
return err
}
if !d.IsDir() {
return nil
}
packs, err := parser.ParseDir(token.NewFileSet(), path, nil, 0)
if err != nil {
return err
}
for packageName, packageObj := range packs {
if slices.Contains(ignorablePackages, packageName) {
return fs2.SkipDir
Expand Down Expand Up @@ -171,6 +180,9 @@ func (checker *TableInfoChecker) ensureCoverage() errors.Error {
return fs2.SkipDir
}
packs, err := parser.ParseDir(token.NewFileSet(), path, nil, parser.PackageClauseOnly)
if err != nil {
return err
}
for _, pk := range packs {
if pk.Name == "main" {
packagesFound++
Expand Down

0 comments on commit d3bc54b

Please sign in to comment.